Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix serverDataSyncer Mixin for Tweakeroo 1.21+ #84

Merged
merged 16 commits into from
Nov 29, 2024
Merged

fix serverDataSyncer Mixin for Tweakeroo 1.21+ #84

merged 16 commits into from
Nov 29, 2024

Conversation

sakura-ryoko
Copy link
Contributor

@sakura-ryoko sakura-ryoko commented Nov 21, 2024 •
edited
Loading

Seems that tweakeroo has been overlooked for 1.21, so I gave it the same treatment as MiniHUD.

@Fallen-Breath Fallen-Breath mentioned this pull request Nov 26, 2024
Closed
2 tasks
@Fallen-Breath
Copy link
Owner

Some questions:

  • What happened between tweakeroo and tweakermore, starting from what versions
  • Where and why does it breaks
  • How did you fix it, why did you choose this implement
  • What else have you done in this PR in addition to the fix

@sakura-ryoko
Copy link
Contributor Author

sakura-ryoko commented Nov 28, 2024 •
edited
Loading

Some questions:

* What happened between tweakeroo and tweakermore, starting from what versions

Tweakeroo in 1.21 also has the same changes as MiniHUD, instead of just 1.21.3, so the changes that you had under 1.21.3, should also be applied to 1.21, starting with Tweakeroo 0.21.51, https://modrinth.com/mod/tweakeroo/version/0.21.51

* Where and why does it breaks

At Startup

* How did you fix it, why did you choose this implement

Used the same fixes that you've already placed in the 1.21.3 folder, and applied them to 1.21.1 and above.

* What else have you done in this PR in addition to the fix

I've primarily just bumped all of the Jitpack versions to the most recent builds of 1.21, where the Modrinth releases do not necessarily have Release tags. Perhaps they can be added yet instead of the 10 character ID.

Fallen-Breath and others added 9 commits November 28, 2024 14:27
@Fallen-Breath @sakura-ryoko
fix XaeroCommonMinimapWaypointsIngameRendererTester ignoring xaero_mi…
7e581cc 
…nimap
@Fallen-Breath @sakura-ryoko
rename for a proper mixin name
07b35f3
@Fallen-Breath @sakura-ryoko
fix mod tweak xmapWaypointFreecamCompact crash with xaero mods >= 24.6
21a32a8 
it's no longer needed since there is no more freecam issue
resolved Fallen-Breath#86
@sakura-ryoko
Revert unrelated dependency changes.
41fe1c3
@sakura-ryoko
Revert unrelated dependency changes.
8e0ea70
@sakura-ryoko
Revert "fix mod tweak xmapWaypointFreecamCompact crash with xaero m…
48b8b32 
…ods >= 24.6"

This reverts commit 21a32a8.
@sakura-ryoko
Revert "rename for a proper mixin name"
e8fb78b 
This reverts commit 07b35f3.
@sakura-ryoko
Revert "fix XaeroCommonMinimapWaypointsIngameRendererTester ignoring …
4a6ce7f 
…xaero_minimap"

This reverts commit 7e581cc.
@sakura-ryoko
Revert "fix serverDataSyncer Mixin for Tweakeroo"
e24e892 
This reverts commit 2928312.
@sakura-ryoko
Copy link
Contributor Author

sakura-ryoko commented Nov 28, 2024 •
edited
Loading

Currently working on the fix like how you've described without using the pre-processor //$$ method, and putting the Mixin in the 1.21.1 folder.

@sakura-ryoko sakura-ryoko marked this pull request as draft November 28, 2024 20:38
@sakura-ryoko
Copy link
Contributor Author

sakura-ryoko commented Nov 28, 2024 •
edited
Loading

All Set. Sorry, I do not know your exact Line spacing for the mixin, so I just re-copied it from the 1.21.3 folder.

@sakura-ryoko sakura-ryoko marked this pull request as ready for review November 28, 2024 21:08
@Fallen-Breath
Copy link
Owner

lgtm, the patch now is much cleaner than it used to be

@Fallen-Breath Fallen-Breath merged commit c3ceba7 into Fallen-Breath:dev Nov 29, 2024
2 checks passed
Fallen-Breath added a commit that referenced this pull request Nov 29, 2024
@Fallen-Breath
comment hint update for pr #84
823b54e
@sakura-ryoko sakura-ryoko deleted the dev-serverDataSyncer-tweakeroo-fix branch November 29, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fallen-Breath Fallen-Breath Fallen-Breath left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sakura-ryoko @Fallen-Breath