Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lower memory consumption for integration tests. #334

Merged
merged 4 commits into from
Dec 4, 2024
Merged

Lower memory consumption for integration tests. #334

merged 4 commits into from
Dec 4, 2024

Conversation

cabrador
Copy link
Collaborator

This PR lowers memory consumption by fakenet and integration tests by StateDB instances by ~250 MB
Before
Screenshot 2024-11-25 at 9 36 00

After:
Screenshot 2024-11-25 at 9 36 41

part of https://github.com/Fantom-foundation/sonic-admin/issues/50

@cabrador cabrador requested a review from LuisPH3 November 25, 2024 08:37
HerbertJordan
HerbertJordan requested changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@HerbertJordan HerbertJordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the memory reduction, but I think the StateDB capacity should be explicitly controlled by some flag, not implicitly through the fake-net switch.

gossip/evmstore/config.go Outdated Show resolved Hide resolved
cmd/sonicd/app/launcher.go Outdated Show resolved Hide resolved
@HerbertJordan HerbertJordan mentioned this pull request Nov 25, 2024
Merged
@cabrador cabrador force-pushed the c/lower-statedb-memory-in-tests branch 2 times, most recently from f5832d0 to 8b82b1e Compare November 25, 2024 15:51
LuisPH3
LuisPH3 reviewed Nov 25, 2024
View reviewed changes
config/flags/flags.go Outdated Show resolved Hide resolved
@cabrador cabrador force-pushed the c/lower-statedb-memory-in-tests branch from 8b82b1e to e9202d5 Compare November 25, 2024 17:27
@cabrador cabrador marked this pull request as draft November 26, 2024 07:22
@cabrador cabrador force-pushed the c/lower-statedb-memory-in-tests branch from e9202d5 to 77c1324 Compare November 26, 2024 07:31
@cabrador cabrador force-pushed the c/lower-integration-tests-memory branch 2 times, most recently from 0930f2c to e64997f Compare November 26, 2024 12:05
@cabrador cabrador changed the title Lower memory consumption for testnet and integration tests. Lower memory consumption for integration tests. Nov 28, 2024
@cabrador cabrador force-pushed the c/lower-statedb-memory-in-tests branch from 7db6b00 to f75858b Compare November 28, 2024 07:07
@cabrador cabrador marked this pull request as ready for review November 28, 2024 10:37
@cabrador cabrador force-pushed the c/lower-integration-tests-memory branch 2 times, most recently from d4be9bf to e65e7cc Compare November 28, 2024 10:40
LuisPH3
LuisPH3 previously approved these changes Nov 28, 2024
View reviewed changes
@cabrador cabrador force-pushed the c/lower-statedb-memory-in-tests branch from ecadbc9 to 3a6cd1e Compare November 28, 2024 10:48
Base automatically changed from c/lower-integration-tests-memory to develop November 28, 2024 12:17
@cabrador cabrador dismissed LuisPH3’s stale review November 28, 2024 12:17

The base branch was changed.

@cabrador cabrador force-pushed the c/lower-statedb-memory-in-tests branch 3 times, most recently from dd4face to a484991 Compare December 2, 2024 08:01
@cabrador cabrador requested a review from LuisPH3 December 3, 2024 10:08
@cabrador cabrador force-pushed the c/lower-statedb-memory-in-tests branch from a484991 to edda31c Compare December 3, 2024 10:34
HerbertJordan
HerbertJordan previously approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@HerbertJordan HerbertJordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor details. Thanks!

config/flags/flags.go Outdated Show resolved Hide resolved
config/flags/flags.go Outdated Show resolved Hide resolved
integration/makegenesis/genesis.go Outdated Show resolved Hide resolved
@cabrador cabrador force-pushed the c/lower-statedb-memory-in-tests branch from cd2ebdc to 98adebe Compare December 3, 2024 10:54
@cabrador cabrador force-pushed the c/lower-statedb-memory-in-tests branch from 59fcb6b to 85558fb Compare December 4, 2024 07:53
@cabrador cabrador force-pushed the c/lower-statedb-memory-in-tests branch from 85558fb to fd02a53 Compare December 4, 2024 10:09
@cabrador cabrador merged commit 4a2d82b into develop Dec 4, 2024
2 checks passed
@cabrador cabrador deleted the c/lower-statedb-memory-in-tests branch December 4, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HerbertJordan HerbertJordan HerbertJordan approved these changes

@jmpike jmpike Awaiting requested review from jmpike jmpike is a code owner

@thaarok thaarok Awaiting requested review from thaarok thaarok is a code owner

@jenikd jenikd Awaiting requested review from jenikd jenikd is a code owner

@LuisPH3 LuisPH3 Awaiting requested review from LuisPH3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cabrador @HerbertJordan @LuisPH3