Skip to content

Commit

Permalink
Support MLC v3.11
Browse files Browse the repository at this point in the history
  • Loading branch information
FarisR99 committed Nov 17, 2024
1 parent 464a477 commit e411031
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 8 deletions.
8 changes: 5 additions & 3 deletions IMLCGui/MLCProcess.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using System;
using System.Collections.Generic;
using System.Diagnostics;
using System.Threading.Tasks;

Expand All @@ -7,6 +8,7 @@ namespace IMLCGui
internal class MLCProcess
{
private static readonly string VERSION_STRING_PREFIX = "Memory Latency Checker - ";
private static readonly List<string> NEW_VERSIONS = new List<string> { "v3.10", "v3.11" };

public static async Task<string> GetMLCVersion(string processPath)
{
Expand Down Expand Up @@ -66,7 +68,7 @@ public static string GenerateBandwidthArguments(string mlcVersion, bool peakInje
public static string GenerateCacheArguments(string mlcVersion)
{
string mlcArguments = "--c2c_latency";
if ("v3.10".Equals(mlcVersion))
if (NEW_VERSIONS.Contains(mlcVersion))
{
mlcArguments += " -e0";
}
Expand All @@ -80,7 +82,7 @@ public static string GenerateLatencyArguments(string mlcVersion, string injectDe
{
mlcArguments += " -d" + injectDelayOverride;
}
if ("v3.10".Equals(mlcVersion))
if (NEW_VERSIONS.Contains(mlcVersion))
{
mlcArguments += " -e0";
}
Expand All @@ -95,7 +97,7 @@ public static string GenerateQuickBandwidthArguments(string mlcVersion)
public static string GenerateQuickLatencyArguments(string mlcVersion)
{
string mlcArguments = "--latency_matrix";
if ("v3.10".Equals(mlcVersion))
if (NEW_VERSIONS.Contains(mlcVersion))
{
mlcArguments += " -e0";
}
Expand Down
6 changes: 4 additions & 2 deletions IMLCGui/MainWindow.xaml.cs
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,9 @@ public partial class MainWindow : MetroWindow
"20000",
};

private static readonly string MLC_DOWNLOAD_VERSION = "v3.10";
// TODO: Refactor this so that there are not 2 variables to maintain
private static readonly string MLC_DOWNLOAD_VERSION = "v3.11";
private static readonly string MLC_DOWNLOAD_URL = "https://downloadmirror.intel.com/793041/mlc_v3.11.tgz";

private Logger _logger;
private CustomConfig _config;
Expand Down Expand Up @@ -958,7 +960,7 @@ private void BtnConfigureDownload_Click(object sender, RoutedEventArgs e)
{
string zipFileNameWithoutExt = $"mlc_{MLC_DOWNLOAD_VERSION}";
string zipFileName = $"{zipFileNameWithoutExt}.tgz";
string mlcUrl = $"https://www.intel.com/content/dam/develop/external/us/en/documents/{zipFileName}";
string mlcUrl = MLC_DOWNLOAD_URL;
string tmpZipDestination = FileUtils.GetTempPath(zipFileName);

if (this.mlcDownloadCancellationSource != null)
Expand Down
6 changes: 3 additions & 3 deletions IMLCGui/Properties/AssemblyInfo.cs
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
[assembly: AssemblyConfiguration("")]
[assembly: AssemblyCompany("KingFaris10")]
[assembly: AssemblyProduct("IMLCGui")]
[assembly: AssemblyCopyright("Copyright © KingFaris10 2022")]
[assembly: AssemblyCopyright("Copyright © KingFaris10 2022 - 2024")]
[assembly: AssemblyTrademark("")]
[assembly: AssemblyCulture("")]

Expand Down Expand Up @@ -51,5 +51,5 @@
// You can specify all the values or you can default the Build and Revision Numbers
// by using the '*' as shown below:
// [assembly: AssemblyVersion("1.0.*")]
[assembly: AssemblyVersion("1.2.0.0")]
[assembly: AssemblyFileVersion("1.2.0.0")]
[assembly: AssemblyVersion("1.2.1.0")]
[assembly: AssemblyFileVersion("1.2.1.0")]

0 comments on commit e411031

Please sign in to comment.