Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor construction and use of CharsToNameCanonicalizer #1088

Merged
merged 4 commits into from
Aug 24, 2023
Merged

Refactor construction and use of CharsToNameCanonicalizer #1088

merged 4 commits into from
Aug 24, 2023

Conversation

cowtowncoder
Copy link
Member

No description provided.

@cowtowncoder cowtowncoder marked this pull request as ready for review August 24, 2023 04:29
@cowtowncoder
Copy link
Member Author

@pjfanning This is what I ended up doing instead of #1086 -- it should give access to StreamReadConstraints within, to be used for #1078. In the end I think it's slightly better to pass TokenStreamFactory anyway; will need to think if I want same for ByteQuadsCanonicalizer too for same reason (even if no constraints object needed).

@cowtowncoder cowtowncoder merged commit 48c4783 into 2.16 Aug 24, 2023
5 checks passed
@cowtowncoder cowtowncoder deleted the tatu/2.16/char-symbol-table branch August 24, 2023 04:31
@cowtowncoder cowtowncoder mentioned this pull request Aug 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cowtowncoder