Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fail if int overflow in _longNameOffset #1358

Merged
merged 2 commits into from
Nov 9, 2024

Conversation

pjfanning
Copy link
Member

Only people who are seriously abusing JSON and creating names in their JSON that exceed 2 billion chars will hit this.

Copy link
Member

@cowtowncoder cowtowncoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- I'll modify message slightly but logic is solid!

@cowtowncoder
Copy link
Member

Good idea: will merge.

@cowtowncoder cowtowncoder merged commit 818647a into FasterXML:2.19 Nov 9, 2024
6 checks passed
@cowtowncoder cowtowncoder added the 2.19 Issues planned at earliest for 2.19 label Nov 9, 2024
@cowtowncoder cowtowncoder added this to the 2.19.0 milestone Nov 9, 2024
@pjfanning pjfanning deleted the longNameOffset-overflow branch November 9, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.19 Issues planned at earliest for 2.19
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants