Fix filenignore behavior for directories #57
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As by gitignore syntax, directories are differentiated from files by specifying a trailing slash.
Filen's sync does not meet these specifications and fails to match entries with trailing slash. Instead, for the example above, Filen would not ignore the directories until removing the trailing slash. Although seemingly not a big problem, it is not the gititnore behavior and may lead to confusion and frustration.
The reason is laid out in the README ("2. filenames and dirnames") of the used package
ignore
: The package cannot tell files and directories apart given the file path as simple string and requires a trailing slash to do so.Here, I attempted to remedy this behavior at the relevant portions in the code that I could find by passing a trailing slash to the
ignores
function. Most likely that is not done in the most performant and elegant way. Nevertheless, I hope it will inspire to address this minor issue.