Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move tui code to tui package #591

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

brianmcgee
Copy link

It makes PluginTerminalUI available for sops (and other third parties) to support plugins more easily.

@felixfontein
Copy link

From the SOPS point of view, having this as a reusable package would be really great! Basically copy'n'pasting that code over (and keeping it up-to-date) would IMO be a last-resort solution, which I'd like to avoid.

@Mic92
Copy link

Mic92 commented Oct 12, 2024

CI needs a fix:

Error: cmd/age-keygen/keygen.go:161:13: non-constant format string in call to log.Printf

@0x2b3bfa0

This comment has been minimized.

@brianmcgee
Copy link
Author

I missed that the static checks needed to be fixed. I just cherry-picked #589 into this branch.

@FiloSottile, it would be great if we could get this merged 🙏

@pheiduck pheiduck mentioned this pull request Oct 21, 2024
@Mic92
Copy link

Mic92 commented Nov 9, 2024

Friendly ping

@Mic92
Copy link

Mic92 commented Nov 29, 2024

I guess a long-term fork, it is than. Someone else interested in maintaining it? We could create some org that contains both age and sops with this feature. We would probably just need to merge with upstream every once in a while.

@felixfontein
Copy link

@FiloSottile any kind of feedback (like whether this has a chance of eventually getting merged) would be great!

@visualphoenix
Copy link

+1 would be great to have this merged

@NovaViper
Copy link

@brianmcgee hey looks like #589 just got merged!

Makes PluginTerminalUI available for sops (and other third parties) so they can more easily support plugins.
@brianmcgee brianmcgee force-pushed the feat/sops-integration branch from c264201 to 266c094 Compare December 18, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants