-
-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move tui code to tui package #591
base: main
Are you sure you want to change the base?
Conversation
From the SOPS point of view, having this as a reusable package would be really great! Basically copy'n'pasting that code over (and keeping it up-to-date) would IMO be a last-resort solution, which I'd like to avoid. |
CI needs a fix:
|
This comment has been minimized.
This comment has been minimized.
I missed that the static checks needed to be fixed. I just cherry-picked #589 into this branch. @FiloSottile, it would be great if we could get this merged 🙏 |
Friendly ping |
I guess a long-term fork, it is than. Someone else interested in maintaining it? We could create some org that contains both age and sops with this feature. We would probably just need to merge with upstream every once in a while. |
@FiloSottile any kind of feedback (like whether this has a chance of eventually getting merged) would be great! |
+1 would be great to have this merged |
@brianmcgee hey looks like #589 just got merged! |
Makes PluginTerminalUI available for sops (and other third parties) so they can more easily support plugins.
c264201
to
266c094
Compare
It makes PluginTerminalUI available for sops (and other third parties) to support plugins more easily.