Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: remove x/params usage from x/foundation #1234

Open
wants to merge 6 commits into
base: bumpup50
Choose a base branch
from
Open

feat!: remove x/params usage from x/foundation #1234

wants to merge 6 commits into from

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Feb 14, 2024 •
edited
Loading

Description

closes: #1232

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech self-assigned this Feb 14, 2024
@github-actions github-actions bot added the C:x/foundation x/foundation module label Feb 14, 2024
@0Tech 0Tech force-pushed the bump50-foundation-params branch from d432918 to c9155da Compare February 14, 2024 08:43
@0Tech 0Tech marked this pull request as ready for review February 15, 2024 02:30
@0Tech 0Tech requested a review from a team as a code owner February 15, 2024 02:30
@0Tech 0Tech force-pushed the bump50-foundation-params branch from c2405b1 to 3eebf18 Compare February 15, 2024 07:32
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@0Tech 0Tech linked an issue Feb 19, 2024 that may be closed by this pull request
Stop using of x/params in x/foundation #1232
Open
jaeseung-bae
jaeseung-bae approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@jaeseung-bae jaeseung-bae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ulbqb
ulbqb approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@ulbqb ulbqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeseung-bae jaeseung-bae jaeseung-bae approved these changes

@ulbqb ulbqb ulbqb approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@0Tech 0Tech

Labels
A: build A: CI C:x/foundation x/foundation module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stop using of x/params in x/foundation
3 participants
@0Tech @ulbqb @jaeseung-bae