Add option to run tests on 1 randomly-chosen device from the list. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to hiccups in FTL availability, sometimes you may want to distribute your test runs onto different FTL device types. This option allows you to pass in a list of test_devices, but rather than running the test on *all* devices in the list, you can run the tests on one randomly-chosen device from the list instead.
|
LGTM. |
sunmou99
approved these changes
Oct 10, 2023
I'll test this in firebase-cpp-sdk first, and then if it works I'll merge it. Can we create a new release tag for v1.3 once this is merged? |
Sure. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to hiccups in FTL availability, sometimes you may want to distribute your test runs onto different FTL device types.
This option allows you to pass in a list of test_devices, but rather than running the test on all devices in the list, you can run the tests on one randomly-chosen device from the list instead.