-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Make protocol registration a configurable user preference #411
feat: Make protocol registration a configurable user preference #411
Conversation
8d4e70c
to
36535a5
Compare
Improved error reporting by accounting for Electron quirks. |
36535a5
to
e88845d
Compare
Looks good, but I'll double check later today. You shouldn't include non-english strings here. That's CrowdIn's job. Note for the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should only be a simple change
To clarify exactly how this should be handled in the future, should one:
I did see some English in the translation files so I'm guessing 3? Finally, do you want me to drop/alter the translations in accordance with the above proper action from this PR specifically? Or should I leave this one alone? |
It'd be easiest to apply the lang files for non-english from the release branch to yours to deal with conflicts. |
49d183d
to
770461f
Compare
770461f
to
fceaf20
Compare
Prevents the launcher from forcefully overwriting an existing registration for the "flashpoint://" protocol if the user wants to use another application for that.
The default value
true
keeps existing behavior. Setting the value tofalse
not only prevents the launcher from setting itself as the protocol handler, but will remove a prior registration of itself if present.The non-English strings are all via Google Translate, which I figured was better than nothing.