Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix toasts sounds playing when disabled #415

Open
wants to merge 1 commit into
base: 1.21/dev
Choose a base branch
from

Conversation

mitw153
Copy link

@mitw153 mitw153 commented Sep 22, 2024

This PR addresses an issue where disabling specific toast types (e.g., tutorial toasts) only prevents the visual display, but the associated sound still plays. The root cause of this issue is that the mod was disabling the rendering of the toast but not the sound.

To resolve this, I extended the logic used when disabling all toasts. Specifically, I modified the injection point to check for individual toast types by evaluating the toast variable. This ensures that, in addition to disabling the render, the sound is also suppressed if the toast type is disabled in the settings and the instance matches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant