feat(mrs): mrs resources not tested #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmicheneau
added
feature
category/mrs
dmicheneau
changed the title
dmicheneau
changed the title
azrod
reviewed
Jan 20, 2023
config/groups.go
Outdated
Comment on lines
160
to
161
| "flexibleengine_mrs_cluster_v2": ReplaceGroupWords("mrs", 1), // Group: mrs, Kind: Cluster | ||
| "flexibleengine_mrs_job_v2": ReplaceGroupWords("mrs", 1), // Group: mrs, Kind: Job |
There was a problem hiding this comment.
old writes...i fix it
config/mrs/config.go
Outdated
| r.UseAsync = true | ||
| // cluster_id | ||
| r.References["cluster_id"] = config.Reference{ | ||
| Type: tools.GenerateType("mrs", "Cluster"), |
There was a problem hiding this comment.
In same resource it's recommended to use local type.
Suggested change
| Type: tools.GenerateType("mrs", "Cluster"), | |
| Type: "Cluster", |
dmicheneau
changed the title
|
Please edit title of PR. Only cluster resource has tested |
dmicheneau
changed the title
dmicheneau
force-pushed
the
123-mrs-resources-not-tested
branch
2 times, most recently
from
589939a
to
1502c03
Compare
dmicheneau
force-pushed
the
123-mrs-resources-not-tested
branch
from
1502c03
to
4d00dc1
Compare
azrod
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
feat(mrs/cluster): Add MRS Cluster example
chore(mrs/job): find an issue #140
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested