Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

Added many languages and a Danish translation #23

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

DandelionSprout
Copy link

I felt I wanted to spend my morning on doing something, so I decided to add a whole bunch of languages and a Danish translation.

One thing to note, is that I decided to look into how to add script-specific versions of languages, most notably for Serbian. The information that was out there was pretty lackluster, but when it came to translation-values folder names, b+(ISO code)+Latn and b+(ISO code)+Cyrl was said to have the highest success percentage, especially on Android ≥7.0. Nevertheless I can't guarantee first-hand if those language codes that I've added in this pull will actually work or not.

@DandelionSprout
Copy link
Author

This pull also aims to resolve #21, for good measure.

@Flo354
Copy link
Owner

Flo354 commented Sep 1, 2018

Hi @DandelionSprout

Thanks for the PR. It's good, but I have a little concern about b+(ISO code)+Latn and b+(ISO code)+Cyrl.

Could you test if they work or at least, do not create some side effects?

@DandelionSprout
Copy link
Author

How would I be able to test it, in that case?

@Flo354
Copy link
Owner

Flo354 commented Sep 1, 2018

Two questions came to my mind:

  • If the user has a device with Android < 7.0, will the app crash when trying to resolve the locale?
  • If an app is compiled with build tools < 24, will the app crash?

@DandelionSprout
Copy link
Author

I'll be honest and say that I have no idea, as I've never made any Android apps of my own.

So I decided to do some additional research on the matter, and while there yet again wasn't many non-theorethical examples for me to go by, it seems to me that only a few Android debug tools currently use b+sr+Latn, based on a source file that I haven't been able to identify, but which uses the same strings and translations as in http://www.ims.co.ke/okoth/insuranceApp/platforms/android/build/intermediates/exploded-aar/com.android.support/appcompat-v7/25.2.0/res/values-b+sr+Latn/values-b+sr+Latn.xml. Additionally, there seems to be zero examples of the other b+-tags being in use at the moment.

@DandelionSprout
Copy link
Author

If it becomes an obstacle to getting the pull request accepted, I could always remove b+sr+Latn as well, if you were to want me to do so.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants