Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FB] Split View | Use TS and SolidJS #80

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

TheChilledBuffalo
Copy link
Collaborator

This PR replaces the JS implementation of Split View with TS and SolidJS.

@surapunoyousei
Copy link
Member

Could you send same implementation to NyanRus/Noraneko ?

Copy link
Member

@surapunoyousei surapunoyousei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost code are good! Use Class provides us more clear code base.

nora/src/content/browser-splitView/browser-splitView.tsx Outdated Show resolved Hide resolved
nora/src/solid-xul/jsx-runtime.ts Outdated Show resolved Hide resolved
@TheChilledBuffalo
Copy link
Collaborator Author

Could you send same implementation to NyanRus/Noraneko ?

Ok I will set it to Noraneko. Could you check if the changes I made are correct? I'll open a PR in Noraneko after the review here.

@surapunoyousei
Copy link
Member

おk

@nyanrus
Copy link
Contributor

nyanrus commented Jun 28, 2024

I suggest to use namespace
if you don't need to initialize, the namespace is better than class with static

@TheChilledBuffalo
Copy link
Collaborator Author

@nyanrus Thank you for the recommendation! Namespaces are actually better than using class here. I have committed the changes. Could you check if the changes are good?

Copy link
Contributor

@nyanrus nyanrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good!
please check the change request

nora/src/content/browser-splitView/browser-splitView.pcss Outdated Show resolved Hide resolved
nora/src/content/browser-splitView/browser-splitView.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@nyanrus nyanrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants