-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FB] Split View | Use TS and SolidJS #80
base: main
Are you sure you want to change the base?
Conversation
Could you send same implementation to NyanRus/Noraneko ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost code are good! Use Class provides us more clear code base.
Ok I will set it to Noraneko. Could you check if the changes I made are correct? I'll open a PR in Noraneko after the review here. |
おk |
I suggest to use namespace |
@nyanrus Thank you for the recommendation! Namespaces are actually better than using class here. I have committed the changes. Could you check if the changes are good? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems good!
please check the change request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍️
This PR replaces the JS implementation of Split View with TS and SolidJS.