Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regression test cases for IIR filter #1429

Merged
merged 12 commits into from
Nov 17, 2024
Merged

Add regression test cases for IIR filter #1429

merged 12 commits into from
Nov 17, 2024

Conversation

derselbst
Copy link
Member

This adds a custom target to the build system check_manual that invokes rendering several test-MIDI files. The test files, along with potentially pre-rendered demonstration audio clips are checked into git lfs. The audio files rendered during build-time are stored in build/test/manual/ and can be used as reference, whenever a part of fluidsynth's logic is about to change. Esp. useful when changing legacy code, as in e.g. #1345.

For the beginning, test files for the IIR filter have been added, taken from issues #1415, #1417, #1424, and #1427.

Additionally, an interactive Bode-Plot for the IIR filter has been added written in Matlab.

@derselbst derselbst added this to the 2.4 milestone Nov 16, 2024
@spessasus
Copy link
Contributor

#1427 is not related to the filter changes as it affects 2.3 and older, it is related to the order of operations in rvoice_write. It still should be included as a test case, but it is not related in any way to #1345, so maybe in a different folder?

@derselbst
Copy link
Member Author

#1427 is not related to the filter changes

I don't think I have claimed that. However, #1427 seems to be caused by the filter's behavior, or at least the filter is involved here. That's why I currently believe it makes sense to keep it in the iir_filter subfolder.

@derselbst derselbst merged commit 069a176 into master Nov 17, 2024
68 of 77 checks passed
@derselbst derselbst deleted the iir-test-files branch November 17, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants