Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Expr(:boundscheck) #1462

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Handle Expr(:boundscheck) #1462

merged 2 commits into from
Jan 8, 2024

Conversation

ToucheSir
Copy link
Member

Fixes #1438. We follow the same route as Diffractorand Umlaut/Yota by always turning on bounds checking for correctness.

PR Checklist

  • Tests are added
  • [N/A] Documentation, if applicable

@ToucheSir
Copy link
Member Author

Bump on this as I work through the list of failures on nightly CI.

@ToucheSir ToucheSir merged commit 392a1f9 into master Jan 8, 2024
12 of 14 checks passed
@ToucheSir ToucheSir deleted the bc/rm-boundscheck branch January 8, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjoint of Adjoint with NamedTuples
2 participants