Add support for mass assignment in Rails 4 and 5 #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaudbesnier
force-pushed
the
devel
branch
7 times, most recently
from
1216774 to
23e6368
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist:
Not sure if this is your preferred way of fixing the underlying issue, since I don't quite fully understand the
aritymethod forupdate_attributes!. Reading the source code, it looks like it should always be 1 for Rails 4 and 5, so I'm confused as to why it was breaking our Rails 5 code. Even the tests never hit the alternate updatewithout_protection: true.