Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(authentication): fix certificate issues that break the authentication #522

Merged
merged 2 commits into from
Sep 30, 2021
Merged

fix(authentication): fix certificate issues that break the authentication #522

merged 2 commits into from
Sep 30, 2021

Conversation

arnaudbesnier
Copy link
Member

@arnaudbesnier arnaudbesnier commented Sep 30, 2021 •
edited
Loading

Definition of Done

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)

Security

  • Consider the security impact of the changes made

@codeclimate
Copy link

codeclimate bot commented Sep 30, 2021

Code Climate has analyzed commit d38cf30 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 44.9%.

View more on Code Climate.

@jeffladiray jeffladiray self-requested a review September 30, 2021 18:04
@arnaudbesnier arnaudbesnier merged commit 0caa6c5 into main Sep 30, 2021
@arnaudbesnier arnaudbesnier deleted the fix/authentication branch September 30, 2021 18:05
forest-bot added a commit that referenced this pull request Sep 30, 2021
@forest-bot
chore(release): 7.2.2 [skip ci]
2f707b1 
## [7.2.2](v7.2.1...v7.2.2) (2021-09-30)

### Bug Fixes

* **authentication:** fix certificate issues that break the authentication ([#522](#522)) ([0caa6c5](0caa6c5))
@forest-bot
Copy link
Member

🎉 This PR is included in version 7.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@berkos
Copy link

berkos commented Oct 4, 2021

Hi @arnaudbesnier @jeffladiray , Thanks very much for the quick response and the resolution of the issue.
Is it worth mentioning in your Readme that you are monkey patching a functionality of a third party gem until httpclient releases a fix? 🙂

Someone else might be requiring this Gem directly and they would not expect that forest-liana would override the same gem too. As a result they could be getting unexpected behaviour.

@arnaudbesnier
Copy link
Member Author

Hi @berkos thanks for your suggestion.
What kind of unexpected behaviour do you have in mind that would worth being mentioned in the Readme?

alexcru1012 added a commit to alexcru1012/Forest-Rails that referenced this pull request Jun 3, 2024
@alexcru1012
chore(release): 7.2.2 [skip ci]
910bc85 
## [7.2.2](ForestAdmin/forest-rails@v7.2.1...v7.2.2) (2021-09-30)

### Bug Fixes

* **authentication:** fix certificate issues that break the authentication ([#522](ForestAdmin/forest-rails#522)) ([0caa6c5](ForestAdmin/forest-rails@0caa6c5))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffladiray jeffladiray jeffladiray approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arnaudbesnier @forest-bot @berkos @jeffladiray