-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FPE proposal #201
base: develop
Are you sure you want to change the base?
FPE proposal #201
Conversation
Maybe the easiest thing to do is just include a file Only drawback to this approach is that we do have option My proposal is, then :
If the user hasn't overridden the virtual feenableexept(), alert them that they do not appear to have feenableexcept on their system and should consider our DYI option, at their own risk, of course. |
|
||
/* This doesn't appear to actually do anything */ | ||
fclaw2d_vtable_t *vt = fclaw2d_vt(); | ||
signal(SIGFPE, vt->fpe_signal_handler); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also this signal never fires on Apple Silicon
This snippet tests a DYI approach to handling exceptions for the M1 :
fenv.h
andsignal.h
enable_floating_point_exceptions()
.fp_exception_glibc_extension.{c,h}
feeenableexcept
is available.Ideas for code taken from
https://developer.apple.com/forums/thread/689159
and
https://stackoverflow.com/questions/69059981/how-to-trap-floating-point-exceptions-on-m1-macs