-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake improvement for consumption of libsc, p4est and Zlib #295
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Couple of issues here:
|
scivision
force-pushed
the
develop
branch
2 times, most recently
from
January 17, 2024 21:04
05ac210
to
6a2c23c
Compare
this is necessary when using superprojects via FetchContent or Git submodules with add_subdirectory()
cmake: applications default off
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: this may be desired as a squash commit due to back-and-forth implementations that aren't useful to preserve in commit history.
This uses FetchContent and CMake cache variables with Git Submodules to propagate variables from child to parent projects reliably and cleanly. It avoids retesting system capabilities when child projects have already done so e.g. SC_HAVE_UNISTD_H
TODO: I need to fix Thunderegg consumption