Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake improvement for consumption of libsc, p4est and Zlib #295

Closed
wants to merge 28 commits into from

Conversation

scivision
Copy link
Contributor

@scivision scivision commented Jan 5, 2024

NOTE: this may be desired as a squash commit due to back-and-forth implementations that aren't useful to preserve in commit history.

This uses FetchContent and CMake cache variables with Git Submodules to propagate variables from child to parent projects reliably and cleanly. It avoids retesting system capabilities when child projects have already done so e.g. SC_HAVE_UNISTD_H

TODO: I need to fix Thunderegg consumption

@scottaiton
Copy link
Member

Couple of issues here:

  • The CI is failing since it is trying to run p4est tests and failing
  • The geoclaw build is failing since we need the "-cpp" gfortran flag to enable preprocessor directives.
  • This breaks the ThunderEgg external build, thus the ci for ThunderEgg is failing.

@scivision scivision force-pushed the develop branch 2 times, most recently from 05ac210 to 6a2c23c Compare January 17, 2024 21:04
@scottaiton scottaiton changed the base branch from develop to develop-3d February 9, 2024 02:52
@scivision scivision closed this Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants