SDKS-3045 refactor next dont revoke when sso null #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to do the Node.next calls. Added tests that cover policy auths for both Central and Embedded use cases Fixed an issue that if Central login happens the Policy Authentications with OAuth2,0 tokens, revoke the OAuth2.0 tokens
george-bafaloukas-forgerock
requested review from
spetrov,
lsanches,
jeyanthanperiyasamy,
witrisna,
rodrigoareis and
vahancouver
vahancouver
reviewed
Mar 22, 2024
|
|
||
| func next(completion:@escaping NodeCompletion<FRUser>) { | ||
| FRLog.v("Called") | ||
| if let currentUser = FRUser.currentUser { |
There was a problem hiding this comment.
In AuthService before the change, this line was:
if let currentUser = FRUser.currentUser, currentUser.token != nil {
Are we not losing anything by not checking for currentUser.token against nil?
| // In this case we are running a transactional authorization flow, the new SSO Token is the same as the originally created one. When running Centralised login, this lived in the browser cookie storage and is unaccesssible from the app | ||
| completion(token, nil, nil) | ||
| return | ||
| } |
There was a problem hiding this comment.
Just to make sure I understand the change, lines 158-162 are the REAL CHANGE to fix the bug we were having right? The rest is just refactoring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket
SDKS-3045
Please, link jira ticket here.
Description
When doing Centralized login, there is no SSO Token. Doing a FRSession.authenticate with policy causes a token revokation, breaking the Transactional Authorization flows when using the OIDC ID Token instead of an SSO Token (cause the app doesn't have it)
Definition of Done Checklist: