refactor: polymorphic component #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlkluth
requested review from
scottrippey,
carloskelly13 and
colinrobertbrooks
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
scottrippey
approved these changes
Nov 9, 2023
colinrobertbrooks
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds Polymorphic types for components
Why
To be more generic, allowing
asprop for rendering.Example
Turn a component that renders a button into a link with
as="a". All of theHTMLAnchorElementtypes now show and are allowed.See also