Support manual service configuration #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ditionalProperties
jevakallio
changed the title
…example for easy testing
kadikraman
approved these changes
Feb 22, 2018
README.md
Outdated
| @@ -72,14 +72,20 @@ const result = await authorize(config); | |||
| This is your configuration object for the client. The config is passed into each of the methods | |||
| with optional overrides. | |||
|
|
|||
| * **issuer** - (`string`) _REQUIRED_ the url of the auth server | |||
| * **issuer** - (`string`) base URI of the authentication server. If no `serviceConfiguration` (below) is not provided, issuer is a mandatory field, so that the configuration can be fetched from the issuer's [OIDC discovery endpoint](https://openid.net/specs/openid-connect-discovery-1_0.html). | |||
There was a problem hiding this comment.
"If no serviceConfiguration (below) is not provided" - double negative 🤔
README.md
Outdated
| @@ -467,6 +481,42 @@ const refreshedState = await refresh(config, { | |||
| }); | |||
| ``` | |||
|
|
|||
| ### Uber | |||
|
|
|||
| Uber provides an OAuth 2.0 endpoint for logging in with a Uber user's credentiala. You'll need to first [create an Uber OAuth application here](https://developer.uber.com/docs/riders/guides/authentication/introduction). | |||
| additionalParametersMap | ||
| ); | ||
| } catch (Exception e) { | ||
| promise.reject(e); |
There was a problem hiding this comment.
In other parts of the app we've been more explicit with the error, e.g.
promise.reject("RNAppAuth Error", "Failed to authenticate", e);
| import java.util.HashMap; | ||
|
|
||
| /** | ||
| * Created by formidable on 21/02/2018. |
There was a problem hiding this comment.
Not sure these "Created by" comments are particularly useful.
index.js
Outdated
| (serviceConfiguration && | ||
| typeof serviceConfiguration.authorizationEndpoint === 'string' && | ||
| typeof serviceConfiguration.tokenEndpoint === 'string'), | ||
| 'Config error: you must provide either an issue or a service endpoints' |
There was a problem hiding this comment.
"an issuer or a service endpoint"
index.js
Outdated
| invariant( | ||
| typeof issuer === 'string' || | ||
| (serviceConfiguration && typeof serviceConfiguration.revocationEndpoint === 'string'), | ||
| 'Config error: you must provide either an issue or a revocation endpoint' |
|
@kadikraman fixed review notes, thanks! When you merge this, feel free to squash, the commit messages are not particularly useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23.
Adds support for manually configuring service endpoints and supporting client secrets for non-OIDC-compliant OAuth services.
JavaScript
authorizerefreshrevokeAndroid
iOS
Other
With this, we should next be able to implement: