Updates Rollbax to use :logger
rather than :error_logger
#127
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connects to #126
note: I know this repository is no longer actively maintained based on the interaction in #122. @jgmchan, @whatyouhide, @lexmag, If you want, you can transfer the repo and hex package to
revelrylabs
and we can take over maintenanceOverview
We recently upgraded to Elixir 1.15 on several of our apps, and noticed that certain errors like LiveView process crashes were no longer being sent to Rollbar despite having
enable_crash_reports
enabled.The problem appears to be related to the fact that Rollbax registers itself as a handler to the old :error_logger, while Elixir has been moving to :logger instead.
There's a little more background and discussion in this issue: elixir-lang/elixir#13030
What's changed
Rollbax.Logger
module in favour ofRollbax.LoggerHandler
:logger
, rather than calling:error_logger.add_report_handler