impl core::error::Error under a feature

Foundation-Devices · Nov 20, 2024 · 621f7dc · 621f7dc
1 parent ded401b
commit 621f7dc
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/stratum-v1/Cargo.toml b/stratum-v1/Cargo.toml
@@ -24,10 +24,11 @@ serde = { workspace = true }
 serde-json-core = { workspace = true, features = ["custom-error-messages"] }
 
 [features]
+core-error = [] # bump MSRV to 1.81.0
 defmt-03 = [
     "dep:defmt",
     "embedded-io-async/defmt-03",
-    # "faster-hex/defmt-03", # will enable it after faster-hex publish PR#54
+    # "faster-hex/defmt-03", # will enable it after faster-hex publish 0.11
     "heapless/defmt-03",
     "serde-json-core/defmt",
 ]

diff --git a/stratum-v1/src/error.rs b/stratum-v1/src/error.rs
@@ -73,9 +73,11 @@ pub enum Error {
     HexError(faster_hex::Error),
 }
 
-// impl core::error::Error for Error {}
+#[cfg(feature = "core-error")]
+impl<E: core::fmt::Debug> core::error::Error for Error<E> {}
 
-impl core::fmt::Display for Error {
+#[cfg(feature = "core-error")]
+impl<E: core::fmt::Debug> core::fmt::Display for Error<E> {
     fn fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::Result {
         write!(f, "{self:?}")
     }