-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add e2e test for changing a cluster to use DNS in cluster files #1821
Merged
johscheuer
merged 3 commits into
FoundationDB:main
from
johscheuer:e2e-test-use-dns-cluster-file
Oct 5, 2023
Merged
Add e2e test for changing a cluster to use DNS in cluster files #1821
johscheuer
merged 3 commits into
FoundationDB:main
from
johscheuer:e2e-test-use-dns-cluster-file
Oct 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
johscheuer
commented
Oct 4, 2023
Those test failures are already fixed in main. |
AnnigeriShambu
approved these changes
Oct 5, 2023
johscheuer
force-pushed
the
e2e-test-use-dns-cluster-file
branch
from
October 5, 2023 08:28
532cb7e
to
9996681
Compare
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
Result of fdb-kubernetes-operator-pr on Linux CentOS 7
|
johscheuer
commented
Oct 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the failures and they seem to be unrelated to the code changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #1254
Type of change
Please select one of the options below.
Discussion
Testing
Ran the new e2e test manually.
Documentation
Follow-up