Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coordinator fault tolerance check #1827

Merged

Conversation

johscheuer
Copy link
Member

Description

Adding a fault tolerance check for coordinators and only allow operations if all coordinators are up and running. In a fallow up we could use those fault tolerances and only validate them for affected Pods, e.g. only validate the coordinator fault tolerance for coordinator changes.

Type of change

Please select one of the options below.

  • New feature (non-breaking change which adds functionality)

Discussion

Currently the requirement is that all coordinators are up and running. This is the most strict policy.

Testing

I added new unit tests. Some of the existing tests are broken and they need some modification (or the mock setup).

Documentation

Follow-up

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: e5d30c0
  • Duration 2:47:44
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: 2ae7024
  • Duration 2:43:58
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@johscheuer johscheuer added the enhancement New feature or request label Oct 9, 2023
@johscheuer johscheuer marked this pull request as ready for review October 9, 2023 12:35
Copy link
Contributor

@09harsh 09harsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a minor comment.

@johscheuer johscheuer merged commit e390fae into FoundationDB:main Oct 9, 2023
8 checks passed
@johscheuer johscheuer deleted the add-coordinator-fault-tolerance-check branch October 9, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants