Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watermark Extraction Fails If Watermark Fits Exactly One Time #159

Open
mhellmeier opened this issue Nov 27, 2024 · 0 comments · May be fixed by #163
Open

Watermark Extraction Fails If Watermark Fits Exactly One Time #159

mhellmeier opened this issue Nov 27, 2024 · 0 comments · May be fixed by #163
Assignees
Labels
bug Something isn't working component: watermarker Watermarker Library

Comments

@mhellmeier
Copy link
Member

🐞 Bug Report

Describe the Bug

If a watermark fits exactly one time into the cover text (without a seperator character at the end), the watermarker library is unable to extract the watermark. In such a case, the Result type is still successful (result.isSuccess is true), but the extracted watermark itself is empty (result.value is empty).

To Reproduce

Steps to reproduce the behavior:

  1. Use "a" as watermark and "a a a a a a a a a a" as cover text
  2. Watermark the cover text with default configuration (RawTrendmark)
  3. Try to extract
  4. --> The extraction will succeed with an empty watermark inside it

Expected Behavior

The value of the result should not be empty. It should contain the watermark.

System Information

  • Component: watermarker & webinterface
  • Runtime: Ubuntu
  • Version: latest version on main

Additional Context

The initial problem was identified by @eschrewe in a review of another PR (see #139 (comment))

Further, I created a Unit test to demonstrate the problem: 78e6691

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component: watermarker Watermarker Library
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants