Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webinterface): add Trendmark advanced settings #139

Merged
merged 8 commits into from
Nov 28, 2024

Conversation

mhellmeier
Copy link
Member

Description

This pull request adds new checkboxes in the webinterface to support different types of Trendmarks.

Linked Issue(s)

Fixes #103

CLA

By submitting this pull request, I have read the Corporate Contributor License Agreement (CLA) and I hereby accept and sign the CLA.

@mhellmeier mhellmeier added component: webinterface Webinterface GUI feature New feature or request labels Oct 30, 2024
Copy link
Contributor

@Schiphorst-ISST Schiphorst-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just a few suggestions to improve user experience

Copy link
Contributor

@eschrewe eschrewe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I did some additional testing and found some unexpected behaviour, see below.

Copy link
Contributor

@eschrewe eschrewe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you very much!

Copy link
Contributor

@Schiphorst-ISST Schiphorst-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhellmeier mhellmeier merged commit 9e6fb05 into main Nov 28, 2024
6 checks passed
@mhellmeier mhellmeier deleted the feat/webinterface-trendmarks branch November 28, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: webinterface Webinterface GUI feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Trendmark Support to the Webinterface
3 participants