Disable suggestAutoExecute and autoClickIfNeverClicked #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suggestAutoExecute and autoClickIfNeverClicked are two transactions features that help ensure the user only has to click the button once, regardless of any needed EIP-712 signatures or network additions or switches. These features offer a delightful UX where almost all users only have to click the button once. However, these features have a critical bug since the recent upgrade to wagmi v2 where unexpected ExecuteTokenTransfer renders can cause execute() to be called twice in a row, leading to the user being prompted to sign duplicate payment transactions (and duplicate payment if they sign both). This disables suggestAutoExecute and autoClickIfNeverClicked until they can be rebuilt safely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
suggestAutoExecute and autoClickIfNeverClicked are two transactions
features that help ensure the user only has to click the button once,
regardless of any needed EIP-712 signatures or network additions or
switches.
These features offer a delightful UX where almost all users only have to
click the button once.
However, these features have a critical bug since the recent upgrade to
wagmi v2 where unexpected ExecuteTokenTransfer renders can cause
execute() to be called twice in a row, leading to the user being
prompted to sign duplicate payment transactions (and duplicate payment
if they sign both).
This disables suggestAutoExecute and autoClickIfNeverClicked until they
can be rebuilt safely.