imx-gpu-viv: Fix EGL dependencies #1747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrCry0
approved these changes
Feb 7, 2024
otavio
requested changes
Feb 7, 2024
There are no behavioral changes here, just a cleanup to make packaging
lines consistent.
Note that SOLIBS and SOLIBSDEV are set the same as ".so", but the
former is used for main packages and the latter for -dev packages.
Also, drop ${libdir}/libGLESv1*${SOLIBS} from FILES:libgles1-imx-dev.
The rule has no effect since it is also included, correctly, in the
main package FILES:libgles1-imx.
Signed-off-by: Tom Hochstein <[email protected]>
Running tiger from imx-gpu-viv-demos does fail due to the missing -dev package link libOpenVG.so. The problem is the EGL implementation opens each rendering API via dlopen of the unversioned library link. For GLES1 and GLES2, this implementation is handled by including the unversioned library links in their main packages. Do the same for the remaining rendering APIs GL and OpenVG. Fixes: #1744 Diagnosed-by: Benjamin Lemouzy <[email protected]> Signed-off-by: Tom Hochstein <[email protected]>
thochstein
force-pushed
the
imx-gpu-viv
branch
from
00b3768
to
7979b9a
Compare
thochstein
changed the title
thochstein
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For each of the EGL rendering APIs, the EGL implementation does a dlopen for the unversioned library link to the rendering API implementation. So, a runtime dependency is needed for the -dev package of each such rendering API implementation.
Fixes: #1744