Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imx-oei: move to dynamic-layers and add arm-toolchain #1910

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

hiagofranco
Copy link
Contributor

@hiagofranco hiagofranco commented Aug 28, 2024

The recipe depends on meta-arm-toolchain, therefore it should be on
dynamic-layers/arm-toolchain folder. Create it and make the
necessary changes for conf/layer.conf

Fixes: 61beaf5 ("recipes-bsp: introduce imx-oei recipe")

Copy link
Member

@otavio otavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we can make this recipe conditional to the toolchain layer instead of the full arm layer. Could you give it a try?

https://git.yoctoproject.org/meta-arm/tree/meta-arm/conf/layer.conf

Either way, I marked the recipe to do the backport automatically, so once we merge this pull request, it's going to create automatically the backport pull request for us.

@otavio
Copy link
Member

otavio commented Aug 28, 2024

@thochstein, could you ask internally why we need to use the arm toolchain instead of the general one? I'd prefer to drop that dependency and make the recipe general.

That would be done in a future release, but it would be nice to consider this improvement.

@hiagofranco hiagofranco changed the title imx-oei: Move to dynamic-layers imx-oei: move to dynamic-layers and add meta-arm-toolchain Aug 28, 2024
@hiagofranco
Copy link
Contributor Author

I believe we can make this recipe conditional to the toolchain layer instead of the full arm layer. Could you give it a try?

https://git.yoctoproject.org/meta-arm/tree/meta-arm/conf/layer.conf

Either way, I marked the recipe to do the backport automatically, so once we merge this pull request, it's going to create automatically the backport pull request for us.

I am not sure if I got it correct, but I pushed the changes. Please have a look.

@thochstein
Copy link
Contributor

@thochstein, could you ask internally why we need to use the arm toolchain instead of the general one? I'd prefer to drop that dependency and make the recipe general.

That would be done in a future release, but it would be nice to consider this improvement.

We need the generic compiler because the output runs on an m-core, not the main core.

conf/layer.conf Outdated Show resolved Hide resolved
The recipe depends on meta-arm-toolchain, therefore it should be on
dynamic-layers/arm-toolchain folder. Create it and make the necessary
changes for conf/layer.conf.

Fixes: 61beaf5 ("recipes-bsp: introduce imx-oei recipe")
Signed-off-by: Hiago De Franco <[email protected]>
@hiagofranco hiagofranco changed the title imx-oei: move to dynamic-layers and add meta-arm-toolchain imx-oei: move to dynamic-layers and add arm-toolchain Sep 8, 2024
@otavio otavio merged commit bcf6049 into Freescale:master Sep 9, 2024
Copy link

github-actions bot commented Sep 9, 2024

Successfully created backport PR #1930 for scarthgap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants