-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imx-oei: move to dynamic-layers and add arm-toolchain #1910
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we can make this recipe conditional to the toolchain layer instead of the full arm layer. Could you give it a try?
https://git.yoctoproject.org/meta-arm/tree/meta-arm/conf/layer.conf
Either way, I marked the recipe to do the backport automatically, so once we merge this pull request, it's going to create automatically the backport pull request for us.
@thochstein, could you ask internally why we need to use the arm toolchain instead of the general one? I'd prefer to drop that dependency and make the recipe general. That would be done in a future release, but it would be nice to consider this improvement. |
60f3349
to
f866538
Compare
I am not sure if I got it correct, but I pushed the changes. Please have a look. |
We need the generic compiler because the output runs on an m-core, not the main core. |
f866538
to
f45afbe
Compare
The recipe depends on meta-arm-toolchain, therefore it should be on dynamic-layers/arm-toolchain folder. Create it and make the necessary changes for conf/layer.conf. Fixes: 61beaf5 ("recipes-bsp: introduce imx-oei recipe") Signed-off-by: Hiago De Franco <[email protected]>
f45afbe
to
07931ef
Compare
Successfully created backport PR #1930 for |
The recipe depends on meta-arm-toolchain, therefore it should be on
dynamic-layers/arm-toolchain folder. Create it and make the
necessary changes for conf/layer.conf
Fixes: 61beaf5 ("recipes-bsp: introduce imx-oei recipe")