GitHub 144 localizable custom entities #148
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanduvisla
changed the title
kanduvisla
changed the title
|
Wow thank you so much @kanduvisla We will take care of your PR as soon as possible. Cheers, |
|
This worked for me, thanks for sharing. However the denormalization part may be in conflict with the fixed issue #167 |
|
Hello, I'm currently using translatable entities. Thanks for this commit. Will this PR merged soon ? |
ptitkosmos
reviewed
May 9, 2018
| $translation->setLabel($value); | ||
|
|
||
| if ($this->propertyAccessor->isWritable($translation, $propertyPath)) { | ||
| $this->propertyAccessor->setValue($translation, $propertyPath, $value); |
There was a problem hiding this comment.
won't work for labels due to the final "S"
ptitkosmos
reviewed
Jun 22, 2018
| @@ -48,13 +47,38 @@ public function process($item) | |||
| continue; | |||
| } | |||
|
|
|||
| $value = $this->propertyAccessor->getValue($item, $property->getName()); | |||
| $normalizedData[$property->getName()] = $this->normalizer->normalize($value, 'flat'); | |||
| $value = $this->normalizer | |||
There was a problem hiding this comment.
Bug :
provokes an error
An error occurred during the export execution.
> Error #0 in class Doctrine\Common\Persistence\Mapping\MappingException: The class 'Doctrine\ORM\PersistentCollection' was not found in the chain configured name
> spaces Gedmo\Tree\Entity, Oro\Bundle\ConfigBundle\Entity, Oro\Bundle\UserBundle\Entity, Pim\Bundle\CustomEntityBundle\Entity, FOS\OAuthServerBundle\Entity, Pim\
> Bundle\UserBundle\Entity, Pim\Bundle\ApiBundle\Entity, Pim\Bundle\CatalogBundle\Entity, Pim\Bundle\CommentBundle\Entity, Pim\Bundle\DataGridBundle\Entity, Pim\B
> undle\NotificationBundle\Entity, Amepim\Bundle\CatalogBundle\Entity, Amepim\Bundle\CustomEntityBundle\Entity, Amepim\Bundle\DeletedEntityBundle\Entity, Akeneo\C
> omponent\Batch\Model, Akeneo\Component\BatchQueue\Queue, Akeneo\Component\FileStorage\Model, Pim\Component\Catalog\Model, Akeneo\Component\Versioning\Model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up for GitHub issue #144.
I made some additions so the Custom Entity Bundle can properly handle localizable custom entities. I still want to add some unit tests and example code (or update the existing example module), but it would already be great if I could get some feedback if I'm on the right track.
Any feedback is welcome!