-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cXML Version 2.0.0 (PHP 8.2+) #30
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. php-cs with some strict rules
+simple endpoint test removed StatusResponse (not used)
mathielen
force-pushed
the
feat/version-2
branch
from
June 10, 2024 11:17
42f93a3
to
6b87318
Compare
+simple endpoint test removed StatusResponse (not used)
mathielen
force-pushed
the
feat/version-2
branch
from
June 10, 2024 11:26
6b87318
to
a4e23ac
Compare
@mathielen did u had some time to review this PR? |
Not really :( But if you guys had I'm happy to just release it. I will upgrade my projects successively after that. |
…bal namespace import overall active
# Conflicts: # src/CXml/Credential/Registry.php # src/CXml/Processor/HeaderProcessor.php
# Conflicts: # composer.json # src/CXml/Builder/OrderRequestBuilder.php # src/CXml/Processor/Processor.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade and Refactor Library
This pull request includes a comprehensive upgrade and refactor of the library. The key changes are as follows:
readonly
modifier where applicable.doctrine/annotations
and applied strict rules inphp-cs
.jms/serializer
3.30.php-cs-fixer
.Changelog for possible v2.0.0
Breaking Changes
Features
jms/serializer
to version 3.30.Refactoring and Improvements
readonly
modifier for classes, properties, and constants.doctrine/annotations
.php-cs
.Ser
toSerializer
.CI Updates
Style and Code Quality
php-cs-fixer
for consistent code style.Additional Note for Users of Older PHP Versions
If you are using a PHP version older than 8.2, please use the 1.x version of this library. The 2.x version introduces changes that require PHP 8.2 or newer.
To continue using the library with older PHP versions, you can specify the 1.x version in your
composer.json
: