find_method_for_type improvements

[esdrubal]

Description

TraitMap::insert now verifies that type parameters trait constraints are satisfied before throwing a duplicate method error.

find_method_for_type was also changed, so it now checks that trait constraints are satisfied before returning the matched method. It also now does a preemptive TraitMap::insert_trait_implementation_for_type this allow us to have:

impl<Z> S<Z>
where
Z: Cat,
{
    fn foo(self) -> u64 {
        1 
    }
}

impl S<u32> {
    fn foo(self) -> u64 {
        1 
    }
}

and still find both methods. Before the change, the compiler would pick the second implementation without inserting the first one into the trait map.

It was added to find_method_for_type exact matching check that avoids Multiple applicable items in scope error for refs and ref must.

Updated find_method_for_type blanket implementation logic where, when we have impl<T> FromBytes for T and impl FromBytes for DataPoint we pick the second implementation.

TraitMap::insert_trait_implementation_for_type now caches the already inserted types to avoid adding multiple times the same types.

Checklist

• I have linked to any relevant issues.
• I have commented my code, particularly in hard-to-understand areas.
• I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • If my change requires substantial documentation changes, I have requested support from the DevRel team
• I have added tests that prove my fix is effective or that my feature works.
• I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
• I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
• I have requested a review from the relevant team or maintainers.

[codspeed-hq]

CodSpeed Performance Report

Merging #6744 will degrade performances by 45.91%

_{Comparing esdrubal/find_method_for_type_improvements (465d3fc) with master (3639c54)}

Summary

❌ 2 regressions
✅ 20 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	master	esdrubal/find_method_for_type_improvements	Change
❌	compile	5.4 s	10 s	-45.91%
❌	did_change_with_caching	506.3 ms	564.8 ms	-10.35%