Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now allow alpha in icons #20

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Now allow alpha in icons #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e69342
fix(generate): now allow alpha in icons
stephanecopin Oct 27, 2020
53eef58
chore(bundler): run bundler install to update to latest dependencies
stephanecopin Dec 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
200 changes: 117 additions & 83 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,125 +10,155 @@ PATH
GEM
remote: https://rubygems.org/
specs:
addressable (2.6.0)
public_suffix (>= 2.0.2, < 4.0)
activesupport (6.0.3.4)
concurrent-ruby (~> 1.0, >= 1.0.2)
i18n (>= 0.7, < 2)
minitest (~> 5.1)
tzinfo (~> 1.1)
zeitwerk (~> 2.2, >= 2.2.2)
addressable (2.7.0)
public_suffix (>= 2.0.2, < 5.0)
ansi (1.5.0)
aruba (0.14.11)
childprocess (>= 0.6.3, < 3.0.0)
contracts (~> 0.9)
cucumber (>= 1.3.19)
aruba (1.0.3)
childprocess (>= 2.0, < 5.0)
contracts (~> 0.16.0)
cucumber (>= 2.4, < 6.0)
ffi (~> 1.9)
rspec-expectations (>= 2.99)
thor (~> 0.19)
ast (2.4.0)
backports (3.15.0)
builder (3.2.3)
childprocess (2.0.0)
rake (< 13.0)
claide (1.0.2)
rspec-expectations (~> 3.4)
thor (~> 1.0)
ast (2.4.1)
builder (3.2.4)
childprocess (4.0.0)
claide (1.0.3)
claide-plugins (0.9.2)
cork
nap
open4 (~> 1.3)
codecov (0.1.14)
codecov (0.2.12)
json
simplecov
url
coderay (1.1.2)
coderay (1.1.3)
colored2 (3.1.2)
concurrent-ruby (1.1.5)
concurrent-ruby (1.1.7)
contracts (0.16.0)
cork (0.3.0)
colored2 (~> 3.1)
cucumber (3.1.2)
builder (>= 2.1.2)
cucumber-core (~> 3.2.0)
cucumber-expressions (~> 6.0.1)
cucumber-wire (~> 0.0.1)
diff-lcs (~> 1.3)
gherkin (~> 5.1.0)
multi_json (>= 1.7.5, < 2.0)
multi_test (>= 0.1.2)
cucumber-core (3.2.1)
backports (>= 3.8.0)
cucumber-tag_expressions (~> 1.1.0)
gherkin (~> 5.0)
cucumber-expressions (6.0.1)
cucumber-tag_expressions (1.1.1)
cucumber-wire (0.0.1)
danger (6.0.9)
cucumber (5.2.0)
builder (~> 3.2, >= 3.2.4)
cucumber-core (~> 8.0, >= 8.0.1)
cucumber-create-meta (~> 2.0, >= 2.0.2)
cucumber-cucumber-expressions (~> 10.3, >= 10.3.0)
cucumber-gherkin (~> 15.0, >= 15.0.2)
cucumber-html-formatter (~> 9.0, >= 9.0.0)
cucumber-messages (~> 13.1, >= 13.1.0)
cucumber-wire (~> 4.0, >= 4.0.1)
diff-lcs (~> 1.4, >= 1.4.4)
multi_test (~> 0.1, >= 0.1.2)
sys-uname (~> 1.2, >= 1.2.1)
cucumber-core (8.0.1)
cucumber-gherkin (~> 15.0, >= 15.0.2)
cucumber-messages (~> 13.0, >= 13.0.1)
cucumber-tag-expressions (~> 2.0, >= 2.0.4)
cucumber-create-meta (2.0.2)
cucumber-messages (~> 13.0, >= 13.0.1)
sys-uname (~> 1.2, >= 1.2.1)
cucumber-cucumber-expressions (10.3.0)
cucumber-gherkin (15.0.2)
cucumber-messages (~> 13.0, >= 13.0.1)
cucumber-html-formatter (9.0.0)
cucumber-messages (~> 13.0, >= 13.0.1)
cucumber-messages (13.1.0)
protobuf-cucumber (~> 3.10, >= 3.10.8)
cucumber-tag-expressions (2.0.4)
cucumber-wire (4.0.1)
cucumber-core (~> 8.0, >= 8.0.1)
cucumber-cucumber-expressions (~> 10.3, >= 10.3.0)
cucumber-messages (~> 13.0, >= 13.0.1)
danger (8.2.0)
claide (~> 1.0)
claide-plugins (>= 0.9.2)
colored2 (~> 3.1)
cork (~> 0.1)
faraday (~> 0.9)
faraday (>= 0.9.0, < 2.0)
faraday-http-cache (~> 2.0)
git (~> 1.5)
kramdown (~> 2.0)
git (~> 1.7)
kramdown (~> 2.3)
kramdown-parser-gfm (~> 1.0)
no_proxy_fix
octokit (~> 4.7)
terminal-table (~> 1)
danger-rubocop (0.6.1)
danger-rubocop (0.8.1)
danger
rubocop
debase (0.2.2)
debase-ruby_core_source (>= 0.10.2)
debase-ruby_core_source (0.10.5)
diff-lcs (1.3)
debase-ruby_core_source (0.10.11)
diff-lcs (1.4.4)
docile (1.3.2)
faraday (0.15.4)
faraday (1.1.0)
multipart-post (>= 1.2, < 3)
faraday-http-cache (2.0.0)
faraday (~> 0.8)
ffi (1.11.1)
ffi (1.11.1-x64-mingw32)
gherkin (5.1.0)
git (1.5.0)
ruby2_keywords
faraday-http-cache (2.2.0)
faraday (>= 0.8)
ffi (1.13.1)
git (1.7.0)
rchardet (~> 1.8)
hanami-cli (0.3.1)
concurrent-ruby (~> 1.0)
hanami-utils (~> 1.3)
hanami-utils (1.3.2)
hanami-utils (1.3.6)
concurrent-ruby (~> 1.0)
transproc (~> 1.0)
jaro_winkler (1.5.3)
json (2.2.0)
kramdown (2.1.0)
i18n (1.8.5)
concurrent-ruby (~> 1.0)
jaro_winkler (1.5.4)
json (2.3.1)
kramdown (2.3.0)
rexml
kramdown-parser-gfm (1.1.0)
kramdown (~> 2.0)
method_source (0.9.2)
multi_json (1.13.1)
method_source (1.0.0)
middleware (0.1.0)
minitest (5.14.2)
multi_test (0.1.2)
multipart-post (2.1.1)
nap (1.1.0)
no_proxy_fix (0.1.2)
octokit (4.14.0)
octokit (4.19.0)
faraday (>= 0.9)
sawyer (~> 0.8.0, >= 0.5.3)
open4 (1.3.4)
parallel (1.17.0)
parser (2.6.3.0)
ast (~> 2.4.0)
parallel (1.19.2)
parser (2.7.2.0)
ast (~> 2.4.1)
phashion (1.2.0)
powerpack (0.1.2)
pry (0.12.2)
coderay (~> 1.1.0)
method_source (~> 0.9.0)
public_suffix (3.1.1)
protobuf-cucumber (3.10.8)
activesupport (>= 3.2)
middleware
thor
thread_safe
pry (0.13.1)
coderay (~> 1.1)
method_source (~> 1.0)
public_suffix (4.0.6)
rainbow (3.0.0)
rake (10.5.0)
rspec (3.8.0)
rspec-core (~> 3.8.0)
rspec-expectations (~> 3.8.0)
rspec-mocks (~> 3.8.0)
rspec-core (3.8.2)
rspec-support (~> 3.8.0)
rspec-expectations (3.8.4)
rchardet (1.8.0)
rexml (3.2.4)
rspec (3.9.0)
rspec-core (~> 3.9.0)
rspec-expectations (~> 3.9.0)
rspec-mocks (~> 3.9.0)
rspec-core (3.9.3)
rspec-support (~> 3.9.3)
rspec-expectations (3.9.3)
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.8.0)
rspec-mocks (3.8.1)
rspec-support (~> 3.9.0)
rspec-mocks (3.9.1)
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.8.0)
rspec-support (3.8.2)
rspec-support (~> 3.9.0)
rspec-support (3.9.4)
rubocop (0.64.0)
jaro_winkler (~> 1.5.1)
parallel (~> 1.10)
Expand All @@ -140,28 +170,32 @@ GEM
ruby-debug-ide (0.6.1)
rake (>= 0.8.1)
ruby-progressbar (1.10.1)
ruby2_keywords (0.0.2)
sawyer (0.8.2)
addressable (>= 2.3.5)
faraday (> 0.8, < 2.0)
simplecov (0.17.0)
simplecov (0.19.1)
docile (~> 1.1)
json (>= 1.8, < 3)
simplecov-html (~> 0.10.0)
simplecov-console (0.5.0)
simplecov-html (~> 0.11)
simplecov-console (0.7.2)
ansi
simplecov
terminal-table
simplecov-html (0.10.2)
simplecov-html (0.12.3)
sys-uname (1.2.1)
ffi (>= 1.0.0)
terminal-table (1.8.0)
unicode-display_width (~> 1.1, >= 1.1.1)
thor (0.20.3)
transproc (1.1.0)
thor (1.0.1)
thread_safe (0.3.6)
transproc (1.1.1)
tzinfo (1.2.7)
thread_safe (~> 0.1)
unicode-display_width (1.4.1)
url (0.3.2)
zeitwerk (2.4.0)

PLATFORMS
ruby
x64-mingw32

DEPENDENCIES
aruba
Expand All @@ -181,4 +215,4 @@ DEPENDENCIES
simplecov-console

BUNDLED WITH
2.0.2
2.1.4
23 changes: 20 additions & 3 deletions lib/ios_icon_generator/helpers/generate_icon.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,12 @@ def self.generate_icon(icon_path:, output_folder:, types:, parallel_processes: n
'-density',
'400',
base_path,
'-channel',
'rgba',
'-alpha',
'on',
'-colorspace',
'sRGB',
'-type',
'truecolor',
'-resize', "#{size}x#{size}",
'-gravity',
'center',
Expand Down Expand Up @@ -134,7 +136,22 @@ def self.generate_icon(icon_path:, output_folder:, types:, parallel_processes: n
max_size = smaller_sizes.flatten.max
temp_icon_path = File.join(output_folder, ".temp_icon#{is_pdf ? '.pdf' : '.png'}")
begin
system('magick', 'convert', '-density', '400', icon_path, '-colorspace', 'sRGB', '-type', 'truecolor', '-scale', "#{max_size}x#{max_size}", temp_icon_path) if icon_path
system(
'magick',
'convert',
'-density',
'400',
icon_path,
'-colorspace',
'sRGB',
'-channel',
'rgba',
'-alpha',
'on',
'-scale',
"#{max_size}x#{max_size}",
temp_icon_path
) if icon_path
progress&.call(1, total)
Parallel.each(
smaller_sizes,
Expand Down