Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Dry for accessing constants #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use Dry for accessing constants #27

wants to merge 1 commit into from

Conversation

hadiidbouk
Copy link

@hadiidbouk hadiidbouk commented Apr 19, 2023 •
edited
Loading

The error shown:

Screenshot 2023-04-19 at 11 27 31 AM

From hanami/cli repository:

NOTE: For versions 0.4 and below, there was a general purpose CLI utility library with this same name. That library has since been renamed to dry-rb/dry-cli. Please update your Gemfiles accordingly.

The code is outdated, and we need to use Dry instead of Hanami.

harishsaini
harishsaini approved these changes Apr 19, 2023
View reviewed changes
Copy link

@harishsaini harishsaini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelskelton samuelskelton samuelskelton approved these changes

@harishsaini harishsaini harishsaini approved these changes

@husseinala husseinala Awaiting requested review from husseinala

@metatheoretic metatheoretic Awaiting requested review from metatheoretic

@ahujamanish ahujamanish Awaiting requested review from ahujamanish

@mattg8000 mattg8000 Awaiting requested review from mattg8000

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hadiidbouk @harishsaini @samuelskelton