-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(breadcrumb): replace 'strong' with 'breadcrumb' tags #3043
base: main
Are you sure you want to change the base?
Conversation
…tro-breadcrumb # Conflicts: # astro/src/content/docs/_shared/_admin-user-form.mdx # astro/src/content/docs/_shared/_admin-user-registration-form.mdx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - so many breadcrumbs, I feel like a duck!
thanks for the review @tonyblank while merging the latest updates i found a mistake in a few changes we did where it should have been replaced with |
…o-breadcrumb # Conflicts: # astro/src/content/docs/customize/email-and-messages/configure-email.mdx # astro/src/content/docs/customize/look-and-feel/index.mdx # astro/src/content/docs/extend/events-and-webhooks/signing.mdx
@alex-fusionauth I've merged the latest changes and updated some newly introduced The few ones unclear right now are the ones where it refers to navigate to a section rather a full page/tab. |
@alex-fusionauth defined the sections as a |
Here is a file of lines that in most cases need |
astro/src/content/docs/customize/email-and-messages/generic-messenger.mdx
Outdated
Show resolved
Hide resolved
astro/src/content/docs/customize/email-and-messages/messengers.mdx
Outdated
Show resolved
Hide resolved
astro/src/content/docs/lifecycle/authenticate-users/integrations/saml/pagerduty.mdx
Show resolved
Hide resolved
...ntent/docs/lifecycle/manage-users/account-management/_account-management-troubleshooting.mdx
Outdated
Show resolved
Hide resolved
...ntent/docs/lifecycle/manage-users/verification/registration-gate-accounts-until-verified.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Andy Pai <[email protected]>
@andrewpai Working on this at the moment, and wanted to clarify, we will not only change the site content but all blog posts too with the same concept. And according to that i will update the blog section in DocsDevREADME.md with that guideline too. |
Correct, we should make our docs consistent across |
…nd InlineUIElements
…o-breadcrumb # Conflicts: # astro/src/content/docs/lifecycle/authenticate-users/single-sign-on.mdx
@andrewpai can we consider a read-only field still a InlineField or is InlineUIElement preferred? The most common case is the ID field which can be at different stages either of it. And further specifying fields would be good too: can we define all types of form fields e.g. text, drop-down selection, checkbox considered InlineField, defining it as where ever info is being entered? If it comes to the field input, it isn't standardized at the moment we have |
Sorry, I completely missed this. InlineField was created so we could reference a field in an API request or response along with its various annotations, inline to some text vs. called out on its own line. I'm not sure if the read-only field fits that description, but if so then I think InlineField is appropriate. If it isn't a field used in an API then maybe InlineUIElement is better. |
Thanks @andrewpai, We will go ahead and define a read-only form field as InlineField as it is still a form field. fusionauth-site/DocsDevREADME.md Line 42 in d73546e
If it comes to the field input, we go ahead and use the |
solves issue FusionAuth/fusionauth-issues#2572