Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slide between virtual desktops (:chefkiss:) #252

Merged
merged 6 commits into from
Jan 15, 2024
Merged

Slide between virtual desktops (:chefkiss:) #252

merged 6 commits into from
Jan 15, 2024

Conversation

andydotxyz
Copy link
Contributor

Smooth as silk and makes switching desktops so much faster!

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.
  • Public APIs match existing style.

@andydotxyz
Move windows when changing desktop
21446dc 
Animated and much faster :)
@andydotxyz
Update desktop pager UI when desk changes
b11df9e 
Fixes issue where tapping app icon would move
view but not update pager.
@andydotxyz
Just apply directly to avoid more queues
a9d9cca
@andydotxyz
Scroll across multiple monitors
6458c7b 
Use the virtual space extents instead of primary screen.
@andydotxyz andydotxyz marked this pull request as ready for review January 14, 2024 21:43
@coveralls
Copy link

coveralls commented Jan 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7521924988

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 27.977%
Totals Coverage Status
Change from base Build 7521922087: -0.2%
Covered Lines: 1534
Relevant Lines: 5483
💛 - Coveralls

@taigrr
Copy link
Member

taigrr commented Jan 15, 2024

cool! exciting feature

LGTM

@andydotxyz
Copy link
Contributor Author

Thanks @taigrr - if you can add an approving review then it can be merged :)

@andydotxyz andydotxyz merged commit e74cff6 into FyshOS:develop Jan 15, 2024
5 checks passed
@andydotxyz andydotxyz deleted the fix/virtualdeskslide branch January 15, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taigrr taigrr taigrr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andydotxyz @coveralls @taigrr