Skip to content

Commit

Permalink
CI: Fix warnings & deprecation messages in the workflows (#241)
Browse files Browse the repository at this point in the history
### What type of PR is this?

CI: Resolve deprecation & warning messages in workflows 
Enable DependaBot for GitHub actions

### What this PR does / why we need it:

Node16 has been out of support since [September
2023](https://github.com/nodejs/Release/#end-of-life-releases). - more
info in the
[post](https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/)


### Which issue(s) this PR fixes:

Resolves: G-Research/gr-oss#640

------------
#### Test results -
https://github.com/gr-oss-devops/spark-extension/actions/runs/8537197206

It uses external actions
`dawidd6/action-download-artifact@246dbf436b23d7c49e21a7ab8204ca9ecd1fe615`
which needs tobe
# Testing results

🟢 Build JVM -
https://github.com/gr-oss-devops/spark-extension/actions/runs/8537197205

🟠 Build Python -
https://github.com/gr-oss-devops/spark-extension/actions/runs/8537197209
__NOTE__ on upstream, this
[workflow](https://github.com/G-Research/spark-extension/actions/workflows/build-python.yml)
is not run at all

🟢 Build Snapshot -
https://github.com/gr-oss-devops/spark-extension/actions/runs/8537197204
__NOTE__ on upstream, this
[workflow](https://github.com/G-Research/spark-extension/actions/workflows/build-snapshots.yml)
is not run at all

🟢 Check -
https://github.com/gr-oss-devops/spark-extension/actions/runs/8537197212
__NOTE__ this workflow is called from `CI` workflow, it can be verified
it's green
[here](https://github.com/gr-oss-devops/spark-extension/actions/runs/8537197234)

🟢 CI -
https://github.com/gr-oss-devops/spark-extension/actions/runs/8537197234

🟢 Test JVM -
https://github.com/gr-oss-devops/spark-extension/actions/runs/8537197234
__NOTE__ this workflow is called from `CI` workflow, it can be verified
it's green
[here](https://github.com/gr-oss-devops/spark-extension/actions/runs/8537197234)

🟢 Test Python -
https://github.com/gr-oss-devops/spark-extension/actions/runs/8537197234
__NOTE__ this workflow is called from `CI` workflow, it can be verified
it's green
[here](https://github.com/gr-oss-devops/spark-extension/actions/runs/8537197234)

🟢 Test results -
https://github.com/gr-oss-devops/spark-extension/actions/runs/8878086091
  • Loading branch information
ljubon authored May 28, 2024
1 parent ce8737b commit cdcf650
Show file tree
Hide file tree
Showing 9 changed files with 14 additions and 14 deletions.
4 changes: 2 additions & 2 deletions .github/actions/build-whl/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,15 +36,15 @@ runs:

- name: Cache Maven packages
if: github.event_name != 'merge_group'
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: ~/.m2/repository
key: ${{ runner.os }}-mvn-build-${{ inputs.spark-version }}-${{ inputs.scala-version }}-${{ hashFiles('pom.xml') }}
restore-keys: ${{ runner.os }}-mvn-build-${{ inputs.spark-version }}-${{ inputs.scala-version }}-

- name: Cache Pip packages
if: github.event_name != 'merge_group'
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: ~/.cache/pip
key: ${{ runner.os }}-pip-whl-${{ inputs.python-version }}-${{ inputs.spark-version }}
Expand Down
2 changes: 1 addition & 1 deletion .github/actions/build/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ runs:

- name: Cache Maven packages
if: github.event_name != 'merge_group'
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: ~/.m2/repository
key: ${{ runner.os }}-mvn-build-${{ inputs.spark-version }}-${{ inputs.scala-version }}-${{ hashFiles('pom.xml') }}
Expand Down
2 changes: 1 addition & 1 deletion .github/actions/check-compat/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ runs:

- name: Cache Maven packages
if: github.event_name != 'merge_group'
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: ~/.m2/repository
key: ${{ runner.os }}-mvn-check-${{ inputs.spark-version }}-${{ inputs.scala-version }}-${{ hashFiles('pom.xml') }}
Expand Down
4 changes: 2 additions & 2 deletions .github/actions/test-jvm/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ runs:
path: .

- name: Cache Spark Binaries
uses: actions/cache@v3
uses: actions/cache@v4
if: ( ! contains(inputs.spark-version, '-SNAPSHOT') )
with:
path: ~/spark
Expand All @@ -59,7 +59,7 @@ runs:

- name: Cache Maven packages
if: github.event_name != 'merge_group'
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: ~/.m2/repository
key: ${{ runner.os }}-mvn-build-${{ inputs.spark-version }}-${{ inputs.scala-version }}-${{ hashFiles('pom.xml') }}
Expand Down
4 changes: 2 additions & 2 deletions .github/actions/test-python/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ runs:

- name: Cache Maven packages
if: github.event_name != 'merge_group'
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: ~/.m2/repository
key: ${{ runner.os }}-mvn-build-${{ inputs.spark-version }}-${{ inputs.scala-version }}-${{ hashFiles('pom.xml') }}
Expand All @@ -56,7 +56,7 @@ runs:

- name: Cache Pip packages
if: github.event_name != 'merge_group'
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: ~/.cache/pip
key: ${{ runner.os }}-pip-test-${{ inputs.python-version }}-${{ hashFiles(format('python/requirements-{0}_{1}.txt', inputs.spark-compat-version, inputs.scala-compat-version)) }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-snapshots.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Build
uses: ./.github/actions/build
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,19 +10,19 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Cache Maven packages
if: github.event_name != 'merge_group'
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: ~/.m2/repository
key: ${{ runner.os }}-mvn-lint-${{ hashFiles('pom.xml') }}

- name: Setup JDK ${{ inputs.java-compat-version }}
uses: actions/setup-java@v3
uses: actions/setup-java@v4
with:
java-version: '11'
distribution: 'zulu'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Upload
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: Event File
path: ${{ github.event_path }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-results.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:

steps:
- name: Download and Extract Artifacts
uses: dawidd6/action-download-artifact@246dbf436b23d7c49e21a7ab8204ca9ecd1fe615
uses: dawidd6/action-download-artifact@09f2f74827fd3a8607589e5ad7f9398816f540fe
with:
run_id: ${{ github.event.workflow_run.id }}
name: "^Event File$| Test Results "
Expand Down

0 comments on commit cdcf650

Please sign in to comment.