Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue : "Make fancier reports" #6

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ayushtiwari134
Copy link

@ayushtiwari134 ayushtiwari134 commented Oct 15, 2024

This pull request improves the visual design of PDF reports generated by the agent. Key enhancements include:

  • Improved Font Styling: Clean font hierarchy with modern fonts (Helvetica) for better readability.
  • Table Formatting: Alternating row colors, borders, and larger headers for clearer structure.
  • Page Layout: Increased white space, centered titles, and optional logos for a more polished look.
  • Color Scheme: Soft background colors and enhanced contrast for headers and tables.

Linked Issue:

Fixes #2

updates are made in the prefix.py file to add the changes

Copy link
Owner

@GGyll GGyll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only fix the report issue

prefix.py Outdated
@@ -33,11 +33,11 @@
To represent a unit, use the unit number and the building alt_name and address.
To represent a sale, use the sale price and the unit number and the closing date.

If a prompt asks for something 'on' a certain street, court or lane etc. Then make sure to filter that the condobuilding address contains the requested street, court or lane etc.
If a prompt asks for something 'on' a certain street, court, or lane etc., ensure that the condobuilding address contains the requested street, court, or lane etc.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't change this language, it is working now so no need to fix

If prompted to generate a map, use google maps, do not generate any script tags for the map, including the google maps script tag. Only generate the html code for the map.
When generating a map or graph, ONLY return the HTML code required for the map or graph. Do NOT include any additional text, explanations, or descriptions.
If a prompt asks to generate a graph or chart, generate the HTML code for a graph with the Chart.js library, and use the prompt to generate the datapoints from the SQL database. Exclude the script tag for Chart.js as it is not necessary. Important: just provide the HTML, no explanation is needed.
If prompted to generate a map, use Google Maps, do not generate any script tags for the map, including the Google Maps script tag. Only generate the HTML code for the map.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same thing here with the capitalization, no need to change it

prefix.py Outdated

{marker_boilerplate}

If a prompt asks for location data which doesn't pertain to buildings, then use the "google_places" tool to find the relevant information.
When finding distance relative to a building or when prompted for the closest or nearest location to the building, use google_maps_directions with the lat and lon of the core_condobuilding table (ALWAYS WITH THE lat and lon) and the destination address to calculate the distance between the building the destination, repeat for all available destinations and return the destination with the lowest distance from the building.
If a prompt asks for location data which doesn't pertain to buildings, then use the Google Places tool to find the relevant information.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capitalization and spelling were not part of this issue, just fix the reports and leave the rest alone as it was

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay sure thing

Copy link
Owner

@GGyll GGyll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fix the report issue

@ayushtiwari134
Copy link
Author

it is done.

@GGyll
Copy link
Owner

GGyll commented Oct 19, 2024

There are still unresolved comments, just revert the whole file to normal and add only the report stuff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make fancier reports
2 participants