Use GNU sort instead of "external-sort" package #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmdcolin
force-pushed
the
use_gnu_sort
branch
5 times, most recently
from
504e0ac
to
9fe2f58
Compare
|
the sort should be much faster now, and hopefully this should control aberrant memory usage too #with gnu sort
bin/run text-index --out /media/cdiesh/Beezle/Downloads/data/large_names2
4m16s.40 total
#without gnu sort
jbrowse text-index --out /media/cdiesh/Beezle/Downloads/data/large_names
7m40s.51 total |
|
identical output also |
|
might go ahead with merge. we could make external-sort a fallback if no gnu sort exists, but i think this should be ok for most users |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires the user has GNU sort installed, but I think this should be common. If a user is running on windows, they can either install it to their path as a windows version or use WSL. The result should be much faster and more reliable