[GT-172] Add blank line across the codebase for PHP files #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowan04
reviewed
Jun 20, 2023
Sae126V
force-pushed
the
feature/Add-a-blank-line-across-codebase
branch
from
fc04612 to
40e8919
Compare
gregcorbett
requested changes
Aug 14, 2023
Sae126V
force-pushed
the
feature/Add-a-blank-line-across-codebase
branch
from
66ad0f6 to
6dc243f
Compare
Sae126V
force-pushed
the
feature/Add-a-blank-line-across-codebase
branch
2 times, most recently
from
40942ad to
40e8919
Compare
|
Can you rebase this ontop of the latest dev? That should remove the strange character change, as that has been merged in (see #471) separately. |
Sae126V
force-pushed
the
feature/Add-a-blank-line-across-codebase
branch
from
f50e3a9 to
40e8919
Compare
|
Looks like you'll need to update your local copy of the upstream dev branch and rebase again - there's still conflicts. |
Sae126V
force-pushed
the
feature/Add-a-blank-line-across-codebase
branch
5 times, most recently
from
008191b to
16de44e
Compare
Sae126V
force-pushed
the
feature/Add-a-blank-line-across-codebase
branch
2 times, most recently
from
b882bf2 to
92a011b
Compare
Sae126V
force-pushed
the
feature/Add-a-blank-line-across-codebase
branch
from
92a011b to
8f7606b
Compare
|
I've documented the fix to the weirdness here: https://stfc.atlassian.net/wiki/spaces/GTT/pages/160170035/GOCDB+Developement#Troubleshooting, as this isn't the first time we have seen it (#447 (comment)). |
|
Rebased and verified. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a single empty Line across the codebase at the EOF. There won't be any impact in-terms of functionality or behaviour. This change applies ONLY to the codebase.
"Please feel free to give any thoughts or comments on this" ---
"Resolves GT-172"