Update code to reflect the new EGI checkin error message(Master) #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sae126V
changed the title
Sae126V
changed the title
Sae126V
changed the title
Sae126V
force-pushed
the
GT-469-Update-to-CheckIn-related-entitlement-error-Dev-fork
branch
2 times, most recently
from
3bd922e to
8dbcafd
Compare
Sae126V
force-pushed
the
GT-469-Update-to-CheckIn-related-entitlement-error-Dev-fork
branch
from
8dbcafd to
1a810cd
Compare
Sae126V
force-pushed
the
GT-469-Update-to-CheckIn-related-entitlement-error-Dev-fork
branch
2 times, most recently
from
2cb57c9 to
b0fb206
Compare
- Co-authored-by: gregcorbett <[email protected]>
Sae126V
force-pushed
the
GT-469-Update-to-CheckIn-related-entitlement-error-Dev-fork
branch
from
b0fb206 to
16bcadb
Compare
|
Note to Future Greg: It's hard to test this, as you don't have a suitable EGI CheckIn account to test every code path. Manual testing on a dev machine (by forcing the relevant |
|
LGTM, Subject to final role out of 5.12.1-rc.1 into production) I'll approve and merge the PRs (this and #523) tomorrow - this is one of those things we can only really test by putting it in production. |
|
The MariaDB 10.3 checks do seem to have passed: https://github.com/GOCDB/gocdb/actions/runs/10900091938/job/30246944295 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #498
GT-469
If a user authenticates with EGI CheckIn, but does not have the correct permission to view gocdb, they are given a basic error message.
This error message references an older entitlement / the EGI wiki. This should be updated to the newer entitlement and update the references.