Handling query error for duplicate editors (#4424)

* Handling query error for multiple editors * Handling query error for multiple editors
GSA-TTS · Oct 31, 2024 · 8973e32 · 8973e32
1 parent 1c18153
commit 8973e32
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/backend/audit/views/manage_submission_access.py b/backend/audit/views/manage_submission_access.py
@@ -206,9 +206,9 @@ def get(self, request, *args, **kwargs):
         report_id = kwargs["report_id"]
         sac = SingleAuditChecklist.objects.get(report_id=report_id)
 
-        try:
-            Access.objects.get(email=request.user.email, sac=sac, role=self.role)
-        except Access.DoesNotExist:
+        if not Access.objects.filter(
+            email=request.user.email, sac=sac, role=self.role
+        ).exists():
             raise PermissionDenied(
                 "Only Audit Editors may remove audit access for other Audit Editors."
             )
@@ -240,9 +240,9 @@ def post(self, request, *args, **kwargs):
         report_id = kwargs["report_id"]
         sac = SingleAuditChecklist.objects.get(report_id=report_id)
 
-        try:
-            Access.objects.get(email=request.user.email, sac=sac, role=self.role)
-        except Access.DoesNotExist:
+        if not Access.objects.filter(
+            email=request.user.email, sac=sac, role=self.role
+        ).exists():
             raise PermissionDenied(
                 "Only Audit Editors may remove audit access for other Audit Editors."
             )