Skip to content

Commit

Permalink
Remove lighthouse and pa11y from test workflows (#2554)
Browse files Browse the repository at this point in the history
* Remove lighthouse from test workflows.

* Remove lighthouse and pa11y from test workflows.
  • Loading branch information
tadhg-ohiggins authored Oct 19, 2023
1 parent c165d78 commit a3bd0cf
Show file tree
Hide file tree
Showing 2 changed files with 60 additions and 61 deletions.
63 changes: 31 additions & 32 deletions .github/workflows/testing-from-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@ jobs:
env:
ENV: TESTING
SAM_API_KEY: ${{ secrets.SAM_API_KEY }}
DJANGO_BASE_URL: 'http://localhost:8000'
DJANGO_BASE_URL: "http://localhost:8000"
DJANGO_SECRET_LOGIN_KEY: ${{ secrets.DJANGO_SECRET_LOGIN_KEY }}
LOGIN_CLIENT_ID: ${{ secrets.LOGIN_CLIENT_ID }}
SECRET_KEY: ${{ secrets.SECRET_KEY }}
ALLOWED_HOSTS: '0.0.0.0 127.0.0.1 localhost'
ALLOWED_HOSTS: "0.0.0.0 127.0.0.1 localhost"
DISABLE_AUTH: False
steps:
- name: Checkout
Expand All @@ -39,8 +39,7 @@ jobs:

- name: Run Django test suite
working-directory: ./backend
run:
docker compose -f docker-compose.yml run web bash -c 'coverage run --parallel-mode --concurrency=multiprocessing manage.py test --parallel && coverage combine && coverage report -m --fail-under=90 && coverage xml -o coverage.xml'
run: docker compose -f docker-compose.yml run web bash -c 'coverage run --parallel-mode --concurrency=multiprocessing manage.py test --parallel && coverage combine && coverage report -m --fail-under=90 && coverage xml -o coverage.xml'

- name: Copy Coverage From Docker Container
run: |
Expand All @@ -58,31 +57,31 @@ jobs:
show_missing: true
repo_token: ${{ secrets.GITHUB_TOKEN }}

a11y-testing:
runs-on: ubuntu-latest
env:
ENV: TESTING
SAM_API_KEY: ${{ secrets.SAM_API_KEY }}
DJANGO_BASE_URL: 'http://localhost:8000'
DJANGO_SECRET_LOGIN_KEY: ${{ secrets.DJANGO_SECRET_LOGIN_KEY }}
LOGIN_CLIENT_ID: ${{ secrets.LOGIN_CLIENT_ID }}
SECRET_KEY: ${{ secrets.SECRET_KEY }}
ALLOWED_HOSTS: '0.0.0.0 127.0.0.1 localhost'
DISABLE_AUTH: True
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v3
with:
node-version: 18
- name: Start services
working-directory: ./backend
run: |
touch .env
docker compose -f docker-compose.yml up -d
- name: Run Lighthouse CI and pa11y
working-directory: ./backend
run: |
sudo npm ci
npm run test:a11y:lighthouse
npm run test:a11y:pa11y
# a11y-testing:
# runs-on: ubuntu-latest
# env:
# ENV: TESTING
# SAM_API_KEY: ${{ secrets.SAM_API_KEY }}
# DJANGO_BASE_URL: "http://localhost:8000"
# DJANGO_SECRET_LOGIN_KEY: ${{ secrets.DJANGO_SECRET_LOGIN_KEY }}
# LOGIN_CLIENT_ID: ${{ secrets.LOGIN_CLIENT_ID }}
# SECRET_KEY: ${{ secrets.SECRET_KEY }}
# ALLOWED_HOSTS: "0.0.0.0 127.0.0.1 localhost"
# DISABLE_AUTH: True
# steps:
# - uses: actions/checkout@v4
# - uses: actions/setup-node@v3
# with:
# node-version: 18
# - name: Start services
# working-directory: ./backend
# run: |
# touch .env
# docker compose -f docker-compose.yml up -d
#
# - name: Run Lighthouse CI and pa11y
# working-directory: ./backend
# run: |
# sudo npm ci
# npm run test:a11y:lighthouse
# npm run test:a11y:pa11y
58 changes: 29 additions & 29 deletions .github/workflows/testing-from-ghcr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@ jobs:
env:
ENV: TESTING
SAM_API_KEY: ${{ secrets.SAM_API_KEY }}
DJANGO_BASE_URL: 'http://localhost:8000'
DJANGO_BASE_URL: "http://localhost:8000"
DJANGO_SECRET_LOGIN_KEY: ${{ secrets.DJANGO_SECRET_LOGIN_KEY }}
LOGIN_CLIENT_ID: ${{ secrets.LOGIN_CLIENT_ID }}
SECRET_KEY: ${{ secrets.SECRET_KEY }}
ALLOWED_HOSTS: '0.0.0.0 127.0.0.1 localhost'
ALLOWED_HOSTS: "0.0.0.0 127.0.0.1 localhost"
DISABLE_AUTH: False
PGRST_JWT_SECRET: ${{ secrets.PGRST_JWT_SECRET }}
steps:
Expand Down Expand Up @@ -59,30 +59,30 @@ jobs:
show_missing: true
repo_token: ${{ secrets.GITHUB_TOKEN }}

a11y-testing:
runs-on: ubuntu-latest
env:
ENV: TESTING
SAM_API_KEY: ${{ secrets.SAM_API_KEY }}
DJANGO_BASE_URL: 'http://localhost:8000'
DJANGO_SECRET_LOGIN_KEY: ${{ secrets.DJANGO_SECRET_LOGIN_KEY }}
LOGIN_CLIENT_ID: ${{ secrets.LOGIN_CLIENT_ID }}
SECRET_KEY: ${{ secrets.SECRET_KEY }}
ALLOWED_HOSTS: '0.0.0.0 127.0.0.1 localhost'
DISABLE_AUTH: True
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v3
with:
node-version: 16
- name: Start services
working-directory: ./backend
run: |
touch .env
docker compose -f docker-compose.yml up -d
- name: Run Lighthouse CI and pa11y
working-directory: ./backend
run: |
sudo npm ci
npm run test:a11y:lighthouse
npm run test:a11y:pa11y
# a11y-testing:
# runs-on: ubuntu-latest
# env:
# ENV: TESTING
# SAM_API_KEY: ${{ secrets.SAM_API_KEY }}
# DJANGO_BASE_URL: "http://localhost:8000"
# DJANGO_SECRET_LOGIN_KEY: ${{ secrets.DJANGO_SECRET_LOGIN_KEY }}
# LOGIN_CLIENT_ID: ${{ secrets.LOGIN_CLIENT_ID }}
# SECRET_KEY: ${{ secrets.SECRET_KEY }}
# ALLOWED_HOSTS: "0.0.0.0 127.0.0.1 localhost"
# DISABLE_AUTH: True
# steps:
# - uses: actions/checkout@v4
# - uses: actions/setup-node@v3
# with:
# node-version: 16
# - name: Start services
# working-directory: ./backend
# run: |
# touch .env
# docker compose -f docker-compose.yml up -d
# - name: Run Lighthouse CI and pa11y
# working-directory: ./backend
# run: |
# sudo npm ci
# npm run test:a11y:lighthouse
# npm run test:a11y:pa11y

0 comments on commit a3bd0cf

Please sign in to comment.