Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2023-10-05 main -> prod #2427

Merged
merged 8 commits into from
Oct 6, 2023
Merged

2023-10-05 main -> prod #2427

merged 8 commits into from
Oct 6, 2023

Conversation

danswick
Copy link
Contributor

@danswick danswick commented Oct 5, 2023

danswick and others added 2 commits October 5, 2023 22:10
* A first step towards regnerating dissemination

This:

1. Deletes everything in all of the dissemination tables.
2. Goes through all of the SAC objects.
3. If the object has a status of "disseminated"...
3a. We re-run `.disseminate()` on that object.

The `.disseminate()` method also re-assigned cog/over.

* lint

---------

Co-authored-by: Matt Jadud <[email protected]>
@danswick danswick temporarily deployed to production October 5, 2023 23:39 — with GitHub Actions Inactive
@danswick danswick temporarily deployed to staging October 5, 2023 23:39 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Terraform plan for staging

No changes. Your infrastructure matches the configuration.
No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

Warning: Argument is deprecated

  with module.staging.module.database.cloudfoundry_service_instance.rds,
  on /tmp/terraform-data-dir/modules/staging.database/database/main.tf line 14, in resource "cloudfoundry_service_instance" "rds":
  14:   recursive_delete = var.recursive_delete

Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases

(and 2 more similar warnings elsewhere)

✅ Plan applied in Deploy to Staging Environment #60

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Terraform plan for production

No changes. Your infrastructure matches the configuration.
No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

Warning: Argument is deprecated

  with module.domain.cloudfoundry_service_instance.external_domain_instance,
  on /tmp/terraform-data-dir/modules/domain/domain/main.tf line 45, in resource "cloudfoundry_service_instance" "external_domain_instance":
  45:   recursive_delete = var.recursive_delete

Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases

(and 3 more similar warnings elsewhere)

📝 Plan generated in Pull Request Checks #1265

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

File Coverage Missing
All files 88%
api/serializers.py 90% 125-126 131 136
api/test_views.py 96% 105
api/uei.py 87% 17-18 87 119-120 164 168-169
api/views.py 97% 196-197 204-205 226 362-363
audit/excel.py 85% 52 420 436 442 447 452 474-475 487 564 566 568 570 572 729-730 738-744 762-763 773 795
audit/forms.py 47% 22-29 142-149
audit/intake_to_dissemination.py 92% 67-68 197-203 253
audit/models.py 84% 57 59 64 66 213 246 417 435-436 444 466 542-543 547 555 564 570 573-579
audit/test_commands.py 87%
audit/test_mixins.py 90% 112-113 117-119 184-185 189-191
audit/test_validators.py 95% 436 440 608-609 848 855 862 869
audit/utils.py 76% 13 21 38
audit/validators.py 96% 287-288 303-304 514-523
audit/views.py 42% 87-108 131-132 206-207 252-253 264-265 267-271 318-331 334-348 353-366 383-389 394-414 441-445 450-479 522-526 531-551 578-582 587-616 659-663 668-680 683-693 698-710 737-738 743-792 795-835 838-855
audit/cross_validation/additional_ueis.py 93% 33
audit/cross_validation/check_award_ref_declaration.py 90%
audit/cross_validation/check_award_reference_uniqueness.py 93%
audit/cross_validation/check_certifying_contacts.py 87%
audit/cross_validation/check_findings_count_consistency.py 91%
audit/cross_validation/check_ref_number_in_cap.py 90%
audit/cross_validation/check_ref_number_in_findings_text.py 90%
audit/cross_validation/errors.py 78% 30 69
audit/cross_validation/naming.py 68% 178-182
audit/cross_validation/submission_progress_check.py 85% 62 77-80
audit/cross_validation/tribal_data_sharing_consent.py 81% 33 36 40
audit/cross_validation/validate_general_information.py 93% 28-29
audit/fixtures/single_audit_checklist.py 79% 156 232-241
audit/management/commands/load_fixtures.py 46% 39-45
audit/viewlib/submission_progress_view.py 96% 171-172
audit/viewlib/tribal_data_consent.py 34% 23-41 44-79
audit/viewlib/upload_report_view.py 26% 32-35 44 91-115 118-168 176-207
cms/views.py 57% 11-16 29-30
config/urls.py 71% 87
dissemination/migrations/0002_general_fac_accepted_date.py 47% 10-12
djangooidc/backends.py 78% 32 57-63
djangooidc/exceptions.py 66% 19 21 23 28
djangooidc/oidc.py 16% 32-35 45-51 64-70 92-149 153-199 203-226 230-275 280-281 286
djangooidc/views.py 80% 22 43 114
djangooidc/tests/common.py 96%
report_submission/forms.py 92% 35
report_submission/views.py 76% 83 215-216 218 240-241 260-261 287-396 399-409
report_submission/templatetags/get_attr.py 76% 8 11-14 18
support/admin.py 49% 9-10 13 34 37 74 77 82 89-95 98-100 103-104 107-108
support/cog_over.py 90% 30-33 86 93 145
support/signals.py 66% 23-24 31-32
support/test_cog_over.py 98% 134-135 224
support/management/commands/seed_cog_baseline.py 98% 20-21
tools/update_program_data.py 89% 96
users/auth.py 95% 40-41
users/fixtures/user_fixtures.py 91%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 0b40195

@github-merge-queue github-merge-queue bot temporarily deployed to meta October 5, 2023 23:57 Inactive
@github-merge-queue github-merge-queue bot temporarily deployed to dev October 5, 2023 23:58 Inactive
@github-merge-queue github-merge-queue bot temporarily deployed to dev October 5, 2023 23:59 Inactive
@asteel-gsa asteel-gsa temporarily deployed to staging October 6, 2023 09:01 — with GitHub Actions Inactive
@github-merge-queue github-merge-queue bot temporarily deployed to production October 6, 2023 16:14 Inactive
@github-merge-queue github-merge-queue bot temporarily deployed to staging October 6, 2023 16:14 Inactive
* HTML - striptags on errors. Blanket error message on top.

* View - Show ValidationErrors on full_clean and save

---------

Co-authored-by: danswick <[email protected]>
@github-merge-queue github-merge-queue bot temporarily deployed to production October 6, 2023 16:14 Inactive
@github-merge-queue github-merge-queue bot temporarily deployed to staging October 6, 2023 16:14 Inactive
* Lower UEI expectations.

* Delete stray print call.

* Tweak property name in test data.
@github-merge-queue github-merge-queue bot temporarily deployed to staging October 6, 2023 16:35 Inactive
@github-merge-queue github-merge-queue bot temporarily deployed to production October 6, 2023 16:35 Inactive
@github-merge-queue github-merge-queue bot temporarily deployed to production October 6, 2023 16:36 Inactive
@github-merge-queue github-merge-queue bot temporarily deployed to staging October 6, 2023 16:36 Inactive
@github-merge-queue github-merge-queue bot temporarily deployed to meta October 6, 2023 16:57 Inactive
@github-merge-queue github-merge-queue bot temporarily deployed to dev October 6, 2023 16:57 Inactive
@github-merge-queue github-merge-queue bot temporarily deployed to dev October 6, 2023 16:58 Inactive
* #2282 Fixed schema validation bug for federal awards section

* #2282 Updated FederalAward schema to allow negative numbers and applied jsonnet formatting

* #Logic change to handle validation scope issue

* #2331 Bug fix

* Fixes cells with just spaces

We were passing cells with just spaces through, which are an invisible
kind of error for users.

We now strip() strings.

* Lint, remove print

---------

Co-authored-by: Matt Jadud <[email protected]>
Co-authored-by: danswick <[email protected]>
@github-merge-queue github-merge-queue bot temporarily deployed to production October 6, 2023 17:00 Inactive
@github-merge-queue github-merge-queue bot temporarily deployed to staging October 6, 2023 17:00 Inactive
@github-merge-queue github-merge-queue bot temporarily deployed to meta October 6, 2023 17:21 Inactive
@github-merge-queue github-merge-queue bot temporarily deployed to dev October 6, 2023 17:21 Inactive
@github-merge-queue github-merge-queue bot temporarily deployed to dev October 6, 2023 17:22 Inactive
@github-merge-queue github-merge-queue bot temporarily deployed to production October 6, 2023 20:54 Inactive
@github-merge-queue github-merge-queue bot temporarily deployed to staging October 6, 2023 20:54 Inactive
@github-merge-queue github-merge-queue bot temporarily deployed to dev October 6, 2023 21:13 Inactive
@github-merge-queue github-merge-queue bot temporarily deployed to meta October 6, 2023 21:13 Inactive
@github-merge-queue github-merge-queue bot temporarily deployed to dev October 6, 2023 21:14 Inactive
@tadhg-ohiggins tadhg-ohiggins merged commit dad6a58 into prod Oct 6, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants