2023-10-31 main -> prod

[danswick]

Search updates:

• XLSX download view (XLSX download view #2626)
• Inexact matches (Search: inexact matches on name fields #2642)
• Summary page updates (Summary Updates #2605)

[github-actions]

Terraform plan for staging

Plan: 0 to add, 2 to change, 0 to destroy.

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # module.staging.cloudfoundry_app.postgrest will be updated in-place
  ~ resource "cloudfoundry_app" "postgrest" {
      ~ docker_image                    = "ghcr.io/gsa-tts/fac/postgrest@sha256:ded2f8ecea6853f73af1c679cdc6f9b8564978b9a028695bcce001b0a7f7fe3a" -> "ghcr.io/gsa-tts/fac/postgrest@sha256:b1b1d0be42868fe621f1162fbe8734f0121a27fc11ef3e8344dc1e8757a1e436"
        id                              = "db50e549-24c7-4dcf-b30e-e9dee3512be8"
        name                            = "postgrest"
        # (15 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # module.staging.module.clamav.cloudfoundry_app.clamav_api will be updated in-place
  ~ resource "cloudfoundry_app" "clamav_api" {
      ~ docker_image                    = "ghcr.io/gsa-tts/fac/clamav@sha256:36ade787c1348b8a03f467784399d06dd551c76a4460d1d343bb6a01d895622f" -> "ghcr.io/gsa-tts/fac/clamav@sha256:5e6db1d70eccc45e76b2169ed53881970c5bc9c22ef5d2adfbd6a3cabd10e8be"
        id                              = "d1bea029-d2d3-4b68-b16d-b216bcaea573"
        name                            = "fac-av-staging"
        # (15 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

Plan: 0 to add, 2 to change, 0 to destroy.

Warning: Argument is deprecated

  with module.staging.module.database.cloudfoundry_service_instance.rds,
  on /tmp/terraform-data-dir/modules/staging.database/database/main.tf line 14, in resource "cloudfoundry_service_instance" "rds":
  14:   recursive_delete = var.recursive_delete

Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases

(and 2 more similar warnings elsewhere)

✅ Plan applied in Deploy to Staging Environment #77

[github-actions]

Terraform plan for production

Plan: 0 to add, 2 to change, 0 to destroy.

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # module.production.cloudfoundry_app.postgrest will be updated in-place
  ~ resource "cloudfoundry_app" "postgrest" {
      ~ docker_image                    = "ghcr.io/gsa-tts/fac/postgrest@sha256:ded2f8ecea6853f73af1c679cdc6f9b8564978b9a028695bcce001b0a7f7fe3a" -> "ghcr.io/gsa-tts/fac/postgrest@sha256:b1b1d0be42868fe621f1162fbe8734f0121a27fc11ef3e8344dc1e8757a1e436"
        id                              = "70ac44be-3507-4867-a75f-c2d1ab12ee89"
        name                            = "postgrest"
        # (15 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # module.production.module.clamav.cloudfoundry_app.clamav_api will be updated in-place
  ~ resource "cloudfoundry_app" "clamav_api" {
      ~ docker_image                    = "ghcr.io/gsa-tts/fac/clamav@sha256:36ade787c1348b8a03f467784399d06dd551c76a4460d1d343bb6a01d895622f" -> "ghcr.io/gsa-tts/fac/clamav@sha256:5e6db1d70eccc45e76b2169ed53881970c5bc9c22ef5d2adfbd6a3cabd10e8be"
        id                              = "5d0afa4f-527b-472a-8671-79a60335417f"
        name                            = "fac-av-production"
        # (15 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

Plan: 0 to add, 2 to change, 0 to destroy.

Warning: Argument is deprecated

  with module.domain.cloudfoundry_service_instance.external_domain_instance,
  on /tmp/terraform-data-dir/modules/domain/domain/main.tf line 45, in resource "cloudfoundry_service_instance" "external_domain_instance":
  45:   recursive_delete = var.recursive_delete

Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases

(and 3 more similar warnings elsewhere)

📝 Plan generated in Pull Request Checks #1521

[github-actions]

File	Coverage		Missing
All files	87%	✅
api/serializers.py	88%	✅	177-178 183 188
api/test_views.py	95%	✅	103
api/uei.py	88%	✅	87 118-119 163 167-168
api/views.py	98%	✅	195-196 334-335
audit/file_downloads.py	71%	❌	26-44 72-74
audit/forms.py	47%	❌	22-29 142-149
audit/intake_to_dissemination.py	92%	✅	67-68 201-207 257
audit/models.py	86%	✅	58 60 65 67 214 247 420 438-439 447 469 558-559 563 571 580 586
audit/test_commands.py	87%	✅
audit/test_mixins.py	90%	✅	112-113 117-119 184-185 189-191
audit/test_validators.py	95%	✅	436 440 608-609 848 855 862 869
audit/test_views.py	95%	✅	386-418 427-458 467-495
audit/test_workbooks_should_fail.py	88%	✅	56 83-84 88
audit/test_workbooks_should_pass.py	90%	✅	56 81
audit/utils.py	70%	❌	13 21 33-35 38
audit/validators.py	92%	✅	137 189 283-292 299-308 486-490 495-499 515-524
audit/views.py	31%	❌	88-109 132-133 207-208 253-254 265-266 268-272 319-332 335-349 354-367 384-390 395-415 418-446 451-480 483-527 532-552 555-583 588-617 620-664 669-681 684-694 699-711 738-739 744-793 796-836 839-856
audit/cross_validation/additional_ueis.py	93%	✅	33
audit/cross_validation/check_award_ref_declaration.py	90%	✅
audit/cross_validation/check_award_reference_uniqueness.py	93%	✅
audit/cross_validation/check_certifying_contacts.py	87%	✅
audit/cross_validation/check_findings_count_consistency.py	91%	✅
audit/cross_validation/check_ref_number_in_cap.py	90%	✅
audit/cross_validation/check_ref_number_in_findings_text.py	90%	✅
audit/cross_validation/errors.py	78%	❌	30 69
audit/cross_validation/naming.py	93%	✅	182
audit/cross_validation/submission_progress_check.py	95%	✅	79
audit/cross_validation/tribal_data_sharing_consent.py	81%	❌	33 36 40
audit/cross_validation/validate_general_information.py	93%	✅	28-29
audit/fixtures/single_audit_checklist.py	55%	❌	146-183 229-238
audit/intakelib/exceptions.py	71%	❌	7-9 12
audit/intakelib/intermediate_representation.py	92%	✅	27-28 73 91 129 162 200-203
audit/intakelib/mapping_audit_findings.py	97%	✅	51
audit/intakelib/mapping_audit_findings_text.py	97%	✅	51
audit/intakelib/mapping_federal_awards.py	93%	✅	95
audit/intakelib/mapping_util.py	81%	❌	21 25 29 99 104-105 114-120 130 145 150
audit/intakelib/checks/check_all_unique_award_numbers.py	79%	❌	24
audit/intakelib/checks/check_cardinality_of_passthrough_names_and_ids.py	91%	✅
audit/intakelib/checks/check_cluster_name_always_present.py	82%	❌	21
audit/intakelib/checks/check_cluster_total.py	85%	✅	49 65
audit/intakelib/checks/check_federal_award_passed_always_present.py	82%	❌	18
audit/intakelib/checks/check_findings_grid_validation.py	84%	❌	57
audit/intakelib/checks/check_has_all_the_named_ranges.py	84%	❌	52
audit/intakelib/checks/check_is_a_workbook.py	68%	❌	16
audit/intakelib/checks/check_loan_guarantee.py	90%	✅	51
audit/intakelib/checks/check_look_for_empty_rows.py	91%	✅	18
audit/intakelib/checks/check_missing_award_numbers.py	72%	❌	16 22-23
audit/intakelib/checks/check_no_major_program_no_type.py	72%	❌	22 31 40
audit/intakelib/checks/check_no_repeat_findings.py	76%	❌	17 26
audit/intakelib/checks/check_other_cluster_names.py	81%	❌	24 34
audit/intakelib/checks/check_passthrough_name_when_no_direct.py	88%	✅	9 47
audit/intakelib/checks/check_sequential_award_numbers.py	76%	❌	14 22
audit/intakelib/checks/check_show_ir.py	70%	❌	8-14
audit/intakelib/checks/check_start_and_end_rows_of_all_columns_are_same.py	89%	✅	14
audit/intakelib/checks/check_state_cluster_names.py	65%	❌	23-24 34
audit/intakelib/checks/runners.py	95%	✅	132
audit/intakelib/checks/util.py	85%	✅	16 33
audit/management/commands/load_fixtures.py	46%	❌	39-45
audit/viewlib/submission_progress_view.py	89%	✅	111 171-172
audit/viewlib/tribal_data_consent.py	34%	❌	23-41 44-79
audit/viewlib/unlock_after_certification.py	57%	❌	28-47 69-83
audit/viewlib/upload_report_view.py	26%	❌	32-35 44 91-117 120-170 178-209
cms/views.py	57%	❌	11-16 29-30
config/urls.py	71%	❌	81
dissemination/models.py	99%	✅	460
dissemination/search.py	97%	✅
dissemination/views.py	67%	❌	26-28 31-60 127 129 131
dissemination/migrations/0002_general_fac_accepted_date.py	47%	❌	10-12
djangooidc/backends.py	78%	❌	32 57-63
djangooidc/exceptions.py	66%	❌	19 21 23 28
djangooidc/oidc.py	16%	❌	32-35 45-51 64-70 92-149 153-199 203-226 230-275 280-281 286
djangooidc/views.py	80%	❌	22 43 114
djangooidc/tests/common.py	96%	✅
report_submission/forms.py	92%	✅	35
report_submission/views.py	76%	❌	83 215-216 218 240-241 260-261 287-396 399-409
report_submission/templatetags/get_attr.py	76%	❌	8 11-14 18
support/admin.py	88%	✅	76 79 84 91-97 100-102
support/cog_over.py	90%	✅	30-33 86 93 145
support/signals.py	66%	❌	23-24 33-34
support/test_cog_over.py	98%	✅	134-135 224
support/management/commands/seed_cog_baseline.py	98%	✅	20-21
tools/update_program_data.py	89%	✅	96
users/auth.py	95%	✅	40-41
users/models.py	97%	✅	51-52
users/fixtures/user_fixtures.py	91%	✅

Minimum allowed coverage is 85%

Generated by 🐒 cobertura-action against e75b450