-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable New Relic High Security Mode #4053
Conversation
Terraform plan for meta No changes. Your infrastructure matches the configuration.
📝 Plan generated in Pull Request Checks #3455 |
Terraform plan for dev Plan: 1 to add, 0 to change, 1 to destroy.Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
-/+ destroy and then create replacement
Terraform will perform the following actions:
# module.dev.module.cors.null_resource.cors_header must be replaced
-/+ resource "null_resource" "cors_header" {
!~ id = "*******************" -> (known after apply)
!~ triggers = { # forces replacement
!~ "always_run" = "2024-08-12T17:36:54Z" -> (known after apply)
}
}
Plan: 1 to add, 0 to change, 1 to destroy.
Warning: Argument is deprecated
with module.dev-backups-bucket.cloudfoundry_service_instance.bucket,
on /tmp/terraform-data-dir/modules/dev-backups-bucket/s3/main.tf line 14, in resource "cloudfoundry_service_instance" "bucket":
14: recursive_delete = var.recursive_delete
Since CF API v3, recursive delete is always done on the cloudcontroller side.
This will be removed in future releases
(and 6 more similar warnings elsewhere) 📝 Plan generated in Pull Request Checks #3455 |
Minimum allowed coverage is Generated by 🐒 cobertura-action against 414b855 |
76dfaa1
to
219c185
Compare
Will need to discuss with @danswick the nature of this, as if we enable it at an application layer, without doing it at the account level, it shuts down logs from the app. |
414b855
to
ef8bb04
Compare
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
ef8bb04
to
d796fd2
Compare
d796fd2
to
2c36678
Compare
2c36678
to
757946d
Compare
going to close this for now but leave the branch. |
PR simply adds a new New Relic environment variable at startup, allowing the instance to be in High Security Mode.
Once the deploys to
preview
are working again, im going to deploy this and look in new relic to ensure:High Security Mode does change some underlying items, and we want to ensure everything is still functional as we expect.
https://docs.newrelic.com/docs/apm/agents/manage-apm-agents/configuration/high-security-mode/#version2description