-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Digital-33: Adding Views #44
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was adding a preprocess hook to help with the uswds icons in event... can you take a look and see what i might be missing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clmedders I believe this will get you what you need without a preprocess
{{ active_theme_path() }}
. @omerida reminded me of that in his PR. In fact, we can go back and refactor the shortcode templates wit this function too (someday).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok ill update and add a todo in the shortcodes to update them as well!
…-add-views # Conflicts: # composer.lock # composer.log # config/sync/core.entity_view_display.node.short_post.teaser.yml # web/themes/custom/digital_gov/templates/block/block--site-wrapper-footer.html.twig
Jira ticket
DIGITAL-33
Purpose
This PR is setting up the Drupal Views for rendering lists and setting up the twig templates for each one.
Please not there are several
todo:
in these files for us to revisit and update once other work is compeltedIncludes the following PRs that must be merged first
Deployment and testing
Local Setup
lando rebuild -y
and clear cache.QA/Testing instructions
page.html.twig
add{{ drupal_view('<view_name>', 'block_1') }}
and add each of the views createdChecklist for the Developer
Checklist for the Peer Reviewers