Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Digital-33: Adding Views #44

Open
wants to merge 21 commits into
base: develop
Choose a base branch
from
Open

Conversation

clmedders
Copy link
Contributor

@clmedders clmedders commented Nov 18, 2024

Jira ticket

DIGITAL-33

Purpose

This PR is setting up the Drupal Views for rendering lists and setting up the twig templates for each one.

  • includes the twig files, config set up for views and a preprocess file for setting up image path for icons

Please not there are several todo: in these files for us to revisit and update once other work is compelted

Includes the following PRs that must be merged first

Deployment and testing

Local Setup

  1. lando rebuild -y and clear cache.
  2. be sure to log in as an admin as well.

QA/Testing instructions

  1. in the page.html.twig add {{ drupal_view('<view_name>', 'block_1') }} and add each of the views created
  2. review view set up to ensure the admin config is set up correctly
  3. also review twig files to ensure set up is correct for migration

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@clmedders clmedders changed the title Digital-33: Adding Views - WIP Digital-33: Adding Views Nov 20, 2024
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was adding a preprocess hook to help with the uswds icons in event... can you take a look and see what i might be missing?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clmedders I believe this will get you what you need without a preprocess
{{ active_theme_path() }}. @omerida reminded me of that in his PR. In fact, we can go back and refactor the shortcode templates wit this function too (someday).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok ill update and add a todo in the shortcodes to update them as well!

@clmedders clmedders marked this pull request as ready for review November 20, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants